Skip to content

Updates dependencies and improve CI configuration. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavofreze merged 1 commit into from
Feb 10, 2026
Merged

Updates dependencies and improve CI configuration. #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: ${{ env.PHP_VERSION }}
extensions: bcmath
tools: composer:2

- name: Validate composer.json
Expand Down Expand Up @@ -52,7 +51,6 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: ${{ env.PHP_VERSION }}
extensions: bcmath
tools: composer:2

- name: Download vendor artifact from build
Expand All @@ -77,7 +75,6 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: ${{ env.PHP_VERSION }}
extensions: bcmath
tools: composer:2

- name: Download vendor artifact from build
Expand Down
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ test-file: ## Run tests for a specific file (usage: make test-file FILE=path/to/
test-no-coverage: configure-test-environment ## Run all tests without coverage
@${DOCKER_RUN} composer tests-no-coverage

.PHONY: unit-test-no-coverage
unit-test-no-coverage: ## Run unit tests without coverage
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit-test-no-coverage runs the container with --network=tiny-blocks, but unlike test / test-no-coverage it does not depend on configure-test-environment. Running this target on a fresh machine will fail if the network (and related volume) hasn’t been created yet; consider adding configure-test-environment as a prerequisite for this target to match the other test targets.

Suggested change
unit-test-no-coverage: ## Run unit tests without coverage
unit-test-no-coverage: configure-test-environment ## Run unit tests without coverage

Copilot uses AI. Check for mistakes.
@${DOCKER_RUN} composer run unit-tests-no-coverage
Comment on lines +37 to +39
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Make target is named unit-test-no-coverage, but it invokes the Composer script unit-tests-no-coverage (note the plural). Consider aligning these names (either target or script) to reduce confusion and keep naming consistent with existing test-no-coverage conventions.

Suggested change
.PHONY: unit-test-no-coverage
unit-test-no-coverage: ## Run unit tests without coverage
@${DOCKER_RUN} composer run unit-tests-no-coverage
.PHONY: unit-tests-no-coverage unit-test-no-coverage
unit-tests-no-coverage: ## Run unit tests without coverage
@${DOCKER_RUN} composer run unit-tests-no-coverage
unit-test-no-coverage: unit-tests-no-coverage

Copilot uses AI. Check for mistakes.

.PHONY: configure-test-environment
configure-test-environment:
@if ! docker network inspect tiny-blocks > /dev/null 2>&1; then \
Expand Down Expand Up @@ -63,7 +67,7 @@ help: ## Display this help message
| awk 'BEGIN {FS = ":.*? ## "}; {printf "$(YELLOW)%-25s$(RESET) %s\n", $$1, $$2}'
@echo ""
@echo "$$(printf '$(GREEN)')Testing$$(printf '$(RESET)')"
@grep -E '^(test|test-file|test-no-coverage):.*?## .*$$' $(MAKEFILE_LIST) \
@grep -E '^(test|test-file|test-no-coverage|unit-test-no-coverage):.*?## .*$$' $(MAKEFILE_LIST) \
| awk 'BEGIN {FS = ":.*?## "}; {printf "$(YELLOW)%-25s$(RESET) %s\n", $$1, $$2}'
@echo ""
@echo "$$(printf '$(GREEN)')Quality$$(printf '$(RESET)')"
Expand Down
9 changes: 5 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,23 +41,24 @@
"require": {
"php": "^8.5",
"symfony/process": "^7.4",
"tiny-blocks/ksuid": "^1.4",
"tiny-blocks/mapper": "1.2.*",
"tiny-blocks/collection": "1.12.*"
"tiny-blocks/ksuid": "^1.5",
"tiny-blocks/mapper": "^2.0",
"tiny-blocks/collection": "^1.15"
},
"require-dev": {
"ext-pdo": "*",
"phpunit/phpunit": "^11.5",
"phpstan/phpstan": "^2.1",
"dg/bypass-finals": "^1.9",
"squizlabs/php_codesniffer": "^3.13"
"squizlabs/php_codesniffer": "^4.0"
},
"scripts": {
"test": "php -d memory_limit=2G ./vendor/bin/phpunit --configuration phpunit.xml tests",
"phpcs": "php ./vendor/bin/phpcs --standard=PSR12 --extensions=php ./src",
"phpstan": "php ./vendor/bin/phpstan analyse -c phpstan.neon.dist --quiet --no-progress",
"test-file": "php ./vendor/bin/phpunit --configuration phpunit.xml --no-coverage --filter",
"test-no-coverage": "php ./vendor/bin/phpunit --configuration phpunit.xml --no-coverage tests",
"unit-tests-no-coverage": "php ./vendor/bin/phpunit --configuration phpunit.xml --no-coverage --testsuite unit",
"review": [
"@phpcs",
"@phpstan"
Expand Down