Skip to content

Conversation

@gustavofreze
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings February 10, 2026 01:37
@gustavofreze gustavofreze merged commit 3c6851f into main Feb 10, 2026
10 checks passed
@gustavofreze gustavofreze deleted the feature/develop branch February 10, 2026 01:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates PHP dependencies and streamlines local/CI test execution for the tiny-blocks/docker-container library.

Changes:

  • Bump tiny-blocks/* dependencies and squizlabs/php_codesniffer versions in composer.json.
  • Add a Composer script + Make target to run unit tests without coverage.
  • Simplify CI PHP setup by removing explicit bcmath extension installation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
composer.json Updates dependency constraints and adds a unit-test-only, no-coverage Composer script.
Makefile Adds a unit-test-no-coverage target and exposes it in the help output.
.github/workflows/ci.yml Removes explicit bcmath extension configuration from setup-php steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@${DOCKER_RUN} composer tests-no-coverage

.PHONY: unit-test-no-coverage
unit-test-no-coverage: ## Run unit tests without coverage
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit-test-no-coverage runs the container with --network=tiny-blocks, but unlike test / test-no-coverage it does not depend on configure-test-environment. Running this target on a fresh machine will fail if the network (and related volume) hasn’t been created yet; consider adding configure-test-environment as a prerequisite for this target to match the other test targets.

Suggested change
unit-test-no-coverage: ## Run unit tests without coverage
unit-test-no-coverage: configure-test-environment ## Run unit tests without coverage

Copilot uses AI. Check for mistakes.
Comment on lines +37 to +39
.PHONY: unit-test-no-coverage
unit-test-no-coverage: ## Run unit tests without coverage
@${DOCKER_RUN} composer run unit-tests-no-coverage
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Make target is named unit-test-no-coverage, but it invokes the Composer script unit-tests-no-coverage (note the plural). Consider aligning these names (either target or script) to reduce confusion and keep naming consistent with existing test-no-coverage conventions.

Suggested change
.PHONY: unit-test-no-coverage
unit-test-no-coverage: ## Run unit tests without coverage
@${DOCKER_RUN} composer run unit-tests-no-coverage
.PHONY: unit-tests-no-coverage unit-test-no-coverage
unit-tests-no-coverage: ## Run unit tests without coverage
@${DOCKER_RUN} composer run unit-tests-no-coverage
unit-test-no-coverage: unit-tests-no-coverage

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant