-
Notifications
You must be signed in to change notification settings - Fork 202
Add upgrade-on-CAN support #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ad9e3a7
Add upgrade-on-CAN support
THardy98 5026348
Replace QueryableWorkflow with dedicated CAN workflow interface in ve…
THardy98 8ef223f
Suppress deprecation warnings in NexusWorkflowTest to fix CI
THardy98 269eb01
remove excess supression warning from merge conflict
THardy98 0135f11
remove excess supression warning from merge conflict
THardy98 3801eb2
remove conflict markers...
THardy98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
temporal-sdk/src/main/java/io/temporal/common/InitialVersioningBehavior.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package io.temporal.common; | ||
|
|
||
| /** | ||
| * Specifies the versioning behavior for the first task of a new workflow run started via | ||
| * continue-as-new. | ||
| */ | ||
| @Experimental | ||
| public enum InitialVersioningBehavior { | ||
| /** | ||
| * Start the new run with {@link VersioningBehavior#AUTO_UPGRADE} behavior for the first task, | ||
| * upgrading to the latest version. After the first workflow task completes, the workflow uses | ||
| * whatever versioning behavior is specified in the workflow code. | ||
| */ | ||
| AUTO_UPGRADE | ||
| } |
15 changes: 15 additions & 0 deletions
15
temporal-sdk/src/main/java/io/temporal/common/SuggestContinueAsNewReason.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package io.temporal.common; | ||
|
|
||
| /** | ||
| * Reason(s) why the server suggests a workflow should continue-as-new. Multiple reasons can be true | ||
| * at the same time. | ||
| */ | ||
| @Experimental | ||
| public enum SuggestContinueAsNewReason { | ||
| /** Workflow history size is getting too large. */ | ||
| HISTORY_SIZE_TOO_LARGE, | ||
| /** Workflow history has too many events. */ | ||
| TOO_MANY_HISTORY_EVENTS, | ||
| /** Workflow's count of completed plus in-flight updates is too large. */ | ||
| TOO_MANY_UPDATES | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest adding a mention that this requires server > v1.x.y at the time that the current WFT was initially executed; i.e. the list will always be empty on older servers.
It is not always pertinent to mention server versions, but in this specific case, I fear that some user may damage their existing workflow executions if they start using this API with incorrect assumptions.