Conversation
THardy98
force-pushed
the
pr/upgrade-on-can
branch
3 times, most recently
from
13b3773 to
82235fc
Compare
Quinn-With-Two-Ns
approved these changes
Mar 23, 2026
mjameswh
reviewed
Mar 26, 2026
| boolean isContinueAsNewSuggested(); | ||
|
|
||
| /** | ||
| * @return the reasons why continue-as-new is suggested, or an empty list if not suggested. This |
Contributor
There was a problem hiding this comment.
I'd suggest adding a mention that this requires server > v1.x.y at the time that the current WFT was initially executed; i.e. the list will always be empty on older servers.
It is not always pertinent to mention server versions, but in this specific case, I fear that some user may damage their existing workflow executions if they start using this API with incorrect assumptions.
mjameswh
approved these changes
Mar 26, 2026
- Add isTargetWorkerDeploymentVersionChanged() to WorkflowInfo, plumbed through WorkflowTaskStateMachine → WorkflowStateMachines → ReplayWorkflowContext → WorkflowInfoImpl → WorkflowInfo - Add initialVersioningBehavior on ContinueAsNewOptions, allowing workflows to CAN with AUTO_UPGRADE to move to the new version - Wire initialVersioningBehavior encoding in SyncWorkflowContext - Update API proto submodule to include api#709 and #721 changes - Fix NexusWorker deprecation warnings from proto update Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…rsioning test The CAN test workflows no longer inherit unnecessary mySignal/getState methods from QueryableWorkflow. Instead they implement a dedicated ContinueAsNewVersionUpgradeWorkflow interface with execute(int attempt), matching the pattern used by other SDKs (Python/Go/TS/.NET). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add @SuppressWarnings("deprecation") to test methods calling the deprecated setOperationError() API, preventing -Werror from failing the build. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
THardy98
force-pushed
the
pr/upgrade-on-can
branch
from
00ee392 to
0135f11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkflowInfo.isTargetWorkerDeploymentVersionChanged()initialVersioningBehavioroption onContinueAsNewOptionsto support upgrading to the latest version on continue-as-new (AUTO_UPGRADE)ContinueAsNewVersioningBehaviorandtargetWorkerDeploymentVersionChangedfieldsisTargetWorkerDeploymentVersionChanged()override inDummySyncWorkflowContext