fix: Fix data race in CallbackGroup::size() #3056
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The computation of the size was not protected by a mutex, leading to possible data races. Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
jmachowinski
force-pushed
the
data_race_fix
branch
from
b92d3c5 to
1936560
Compare
Collaborator
Author
|
Pulls: #3056
|
ahcorde
approved these changes
Feb 11, 2026
Contributor
|
https://github.com/Mergifyio backport kilted jazzy |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
The computation of the size was not protected by a mutex, leading to possible data races. Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> (cherry picked from commit 4d950ba)
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
The computation of the size was not protected by a mutex, leading to possible data races. Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> (cherry picked from commit 4d950ba)
ahcorde
pushed a commit
that referenced
this pull request
Feb 12, 2026
The computation of the size was not protected by a mutex, leading to possible data races. (cherry picked from commit 4d950ba) Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The computation of the size was not protected by a mutex, leading to possible data races.
Did you use Generative AI?
No
Additional Information
Discovered using helgrind