Conversation
|
1659 |
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
Looks good but needs a few minor fixes 👍
| ) | ||
| } | ||
|
|
||
| private fun extractVideoId(url: String): String? { |
There was a problem hiding this comment.
The Youtube extractor already has this logic, but much better support for various links.
I suggest you remove extractVideoId and let the extractor handle the ID logic.
| return newHomePageResponse( | ||
| listOf( | ||
| HomePageList( | ||
| request.name.ifEmpty { "Trending" }, |
There was a problem hiding this comment.
This isEmpty should never be true, you can remove it.
|
|
||
| extractor.forceContentCountry(ContentCountry(Locale.getDefault().country)) | ||
|
|
||
| val pageData = if (page == 1) { |
There was a problem hiding this comment.
Please add a comment explaining the 'linked list logic' briefly. It is good practice to make it easy to maintain.
Something like: "To fetch the next page we must have a reference to the current page. To do that we store a cache of the current page." would work well.
2 participants
bumps gradle plugin version from 2.1.0 to 2.3.0
Adds Youtube Provider
1, we can delete/ disable invidios app api's are locked
2, will implement channel, playlist as TvSeries Later
4, login and personalisation to be done later
3, rest all other functionality works fine