Youtube Extractor Fix with NewPipe #2489
Open
+55
−231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-light42
requested changes
Feb 11, 2026
Collaborator
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
Very nice pull request, tested it and works well. I only have a comment about the quality cap.
library/src/commonMain/kotlin/com/lagradost/cloudstream3/extractors/YoutubeExtractor.kt
Outdated
Show resolved
Hide resolved
Author
|
Sorry, for all this forced-pushed, i wanted to created a seprate create pr for the extractor, now |
fire-light42
approved these changes
Feb 11, 2026
Collaborator
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
Everything looks good, will merge after testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Bump newpipeextractor
File:
gradle/libs.versions.toml2. YoutubeExtractor Fix
Supports up to 4K.
Testing Mr. Beast's Video 4K Fetched
Screen_recording_20260210_042739.webm
Known Issue - Audio Label's not assiging properly
this mostly happens to additional dubbed audios
i already have some fix, will create another pr for it as it's related to how
newAudioFileis handled