-
Notifications
You must be signed in to change notification settings - Fork 669
[release-4.21] OCPBUGS-76386: i18n upload/download routine task - 4.21 / 281 (Latest) #16006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.21
Are you sure you want to change the base?
Conversation
Adding latest translations from Memsource project https://cloud.memsource.com/web/project2/show/BR9Gy6Rw7ZXW0Ok5ljAW91
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-73871 has been cloned as Jira Issue OCPBUGS-76386. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-76386, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/jira refresh |
|
@cajieh: This pull request references Jira Issue OCPBUGS-76386, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/label backport-risk-assessed |
|
@cajieh: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| "Unable to delete {{revlabel}}": "无法删除 {{revlabel}}", | ||
| "You cannot delete the last {{revlabel}} for the {{serviceLabel}}.": "您不能为 {{serviceLabel}} 删除最后一个 {{revlabel}}。", | ||
| "OK": "确定", | ||
| "OK": "OK", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure that OK should translate to OK here?
| "Cancel": "Cancelar", | ||
| "Restart Export": "Reiniciar exportación", | ||
| "OK": "DE ACUERDO", | ||
| "OK": "De acuerdo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK translates to Spanish here but not above in zh
| "Editor settings": "编辑器设置", | ||
| "Changes apply immediately": "更改会立即应用", | ||
| "OK": "OK", | ||
| "OK": "确定", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we are re-translating "OK": "OK" to "OK": "确定"
| "Access modes": "访问模式", | ||
| "Volume mode": "卷模式", | ||
| "StorageClasses": "存储类", | ||
| "Requested VolumeAttributesClass": "请求的 VolumeAttributesClass", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also translate VolumeAttributesClass to zh as we have done with PersistentVolumeClaim?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K8s resources should not be translated.
| "Editor settings": "编辑器设置", | ||
| "Changes apply immediately": "更改会立即应用", | ||
| "OK": "OK", | ||
| "OK": "确定", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we are re-translating "OK": "OK" to "OK": "确定"
| "Cancel": "Cancelar", | ||
| "Restart Export": "Reiniciar exportación", | ||
| "OK": "DE ACUERDO", | ||
| "OK": "De acuerdo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK translates to Spanish here but not above in zh
| "Maintenance should not be started until the health of the storage cluster is restored.": "不应在存储集群健康恢复前启动维护。", | ||
| "Are you sure you want to stop maintenance <1>{reasonLabel}</1> on node <4>{nodeName}</4>?": "您确定要在节点 <4>{nodeName}</4> 上停止维护 <1>{reasonLabel}</1> 吗 ?", | ||
| "OK": "确定", | ||
| "OK": "OK", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure why 'OK' was changed in several files. I will reach out to the Localization team for clarification. If any changes are required, we can patch them in later.
| "Access modes": "访问模式", | ||
| "Volume mode": "卷模式", | ||
| "StorageClasses": "存储类", | ||
| "Requested VolumeAttributesClass": "请求的 VolumeAttributesClass", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K8s resources should not be translated.
| "VolumeAttributesClass modification in progress": "VolumeAttributesClass 수정 진행 중", | ||
| "VolumeAttributesClass \"{{target}}\" is pending application.": "VolumeAttributesClass \"{{target}}\"은/는 보류 중인 애플리케이션입니다.", | ||
| "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "볼륨 설정이 \"{{current}}\"에서 \"{{target}}\"로 업데이트되고 있습니다. 이 작업은 몇 분 정도 걸릴 수 있습니다.", | ||
| "PersistentVolumeClaim details": "영구 볼륨 클레임 세부 정보", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug. We'll have to address this separately.
Good catch!
|
Hi @cajieh Kindly help confirm whether the fix addresses the issue mentioned on https://issues.redhat.com/browse/OCPBUGS-70011 |
This is an automated cherry-pick of #15976
/assign cajieh