OCPBUGS-73871: i18n upload/download routine task - 4.21 / 281 (Latest) #15976
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@cajieh: This pull request references Jira Issue OCPBUGS-73871, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
added
the
needs-rebase
📝 WalkthroughWalkthroughThis PR updates localization files across multiple frontend packages including console-app, console-shared, dev-console, knative-plugin, metal3-plugin, operator-lifecycle-manager, topology, and public locales. Changes span Japanese, Korean, Spanish, French, and Chinese translations. Key additions include new VolumeAttributesClass-related translation entries and contact mail UI copy. Several translations receive phrasing refinements, capitalization corrections, and terminology adjustments. Some localization entries are removed to reflect UI changes. No exported entity declarations or control logic are modified—all changes are strictly localization content updates. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
openshift-ci
bot
added
component/core
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@cajieh: This pull request references Jira Issue OCPBUGS-73871, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
removed
the
needs-rebase
|
@cajieh: This pull request references Jira Issue OCPBUGS-73871, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 10
🤖 Fix all issues with AI agents
In `@frontend/packages/dev-console/locales/ja/devconsole.json`:
- Line 122: The translation for the JSON key "Argument" is wrong — replace the
value "口論" with the correct UI term "引数" in the devconsole.json entry for
"Argument" so the Japanese string reflects the programming term rather than
"quarrel".
In `@frontend/packages/dev-console/locales/zh/devconsole.json`:
- Line 360: The translation for the JSON key "Request" currently uses "要求" which
is inconsistent with Kubernetes terminology; update the value for the "Request"
key in the devconsole.json locale entry to "请求" so it matches other console
messages (e.g., HPA and resource constraint help text) and maintains consistent
Chinese technical terminology.
In `@frontend/packages/knative-plugin/locales/es/knative-plugin.json`:
- Line 105: The Spanish translation for the "Subscribe" action should be
reflexive; update the JSON entry with key "Subscribe" in knative-plugin.json so
its value becomes "Suscribirse" instead of "Suscribir" to reflect the proper
user-action phrasing.
In `@frontend/public/locales/es/public.json`:
- Line 1146: The Spanish translation for the JSON key "Requested
VolumeAttributesClass" uses a masculine plural adjective ("solicitados") but
needs to be feminine singular; update the value to the correct agreement, e.g.,
change it to "Clase de atributos de volumen solicitada" so the adjective matches
the singular feminine noun "Clase".
- Around line 1132-1137: Remove the extra spaces inside the i18n placeholders
for the two Spanish entries so placeholders render without stray spaces: fix the
value for the key matching VolumeAttributesClass \"{{target}}\" is pending
application. (currently contains \"{{target}} \" ) and the value for the key
matching Your volume settings are being updated from \"{{current}}\" to
\"{{target}}\". This may take a few moments. (currently contains \"{{current}}
\" and \"{{target}} \") — ensure placeholders are exactly {{current}} and
{{target}} with no internal trailing spaces.
In `@frontend/public/locales/fr/public.json`:
- Line 1146: The French translation for the key "Requested
VolumeAttributesClass" has incorrect gender agreement: change the value string
from "Classe d'attributs de volume demandé" to use the feminine past participle
("demandée") so it reads "Classe d'attributs de volume demandée" to agree with
"Classe".
- Around line 1132-1137: The French translation for the key "Your volume
settings are being updated from \"{{current}}\" to \"{{target}}\". This may take
a few moments." still contains the English word "to"; update the value to use
correct French wording, e.g. replace "to" with "à" or "vers" so it reads: "Vos
paramètres de volume sont en cours de mise à jour à partir de \"{{current}}\" à
\"{{target}}\". Cela peut prendre quelques instants." Ensure you update the
exact JSON value for that key ("Your volume settings are being updated from
\"{{current}}\" to \"{{target}}\". This may take a few moments.") in
frontend/public/locales/fr/public.json.
In `@frontend/public/locales/ja/public.json`:
- Around line 1132-1137: The translation for the key "Your volume settings are
being updated from \"{{current}}\" to \"{{target}}\". This may take a few
moments." uses 音量設定 (audio volume) instead of the correct storage term ボリューム設定 —
update that Japanese string to replace 音量設定 with ボリューム設定 so it matches the
storage context and the other entries like "VolumeAttributesClass modification
failed" / "VolumeAttributesClass の変更に失敗しました".
- Around line 1149-1153: The translation for the JSON key "Claim" currently uses
the billing-oriented term "請求"; update this to the Kubernetes-appropriate term
(e.g., "クレーム" or keep "Claim") and confirm with the localization reviewer;
specifically change the value for the "Claim" key (near "PersistentVolumeClaims"
and "No claim") to the agreed term and ensure consistency with other
storage-related keys like "PersistentVolumeClaims".
In `@frontend/public/locales/zh/public.json`:
- Line 1570: Replace the awkward translation for the "Utilized by" key
(currently "被利用") with a more natural UI label; update the JSON entry's value to
"使用者" (or "被使用" if context expects passive phrasing) so the key "Utilized by"
reads naturally in Chinese.
| "Arguments": "引数", | ||
| "Add argument": "引数の追加", | ||
| "Argument": "引数", | ||
| "Argument": "口論", |
There was a problem hiding this comment.
Japanese translation for “Argument” is incorrect.
Line 122 uses “口論” (quarrel). The correct UI term is 引数.
✏️ Proposed fix
- "Argument": "口論",
+ "Argument": "引数",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Argument": "口論", | |
| "Argument": "引数", |
🤖 Prompt for AI Agents
In `@frontend/packages/dev-console/locales/ja/devconsole.json` at line 122, The
translation for the JSON key "Argument" is wrong — replace the value "口論" with
the correct UI term "引数" in the devconsole.json entry for "Argument" so the
Japanese string reflects the programming term rather than "quarrel".
There was a problem hiding this comment.
Not sure if these CodeRabbit translation suggestions are accurate. I'll check with the translations team later on since they're the experts.
There was a problem hiding this comment.
@cajieh That's a sensible approach—verifying with the translations team is the right call.
For context, the same file already translates the related key "Arguments" as "引数" (line 121) and "Add argument" as "引数の追加" (line 120), both using the programming term "引数". The flagged entry at line 122 stands out because "口論" typically means "quarrel" or "dispute" rather than a command-line or function argument.
Feel free to confirm with the translations team and update accordingly if needed.
(\(\
( -.-)
o_(")(") Curious ears up!
| "Resource limit": "资源限值", | ||
| "Resource limits control how much CPU and memory a container will consume on a node.": "资源限值控制容器在节点上消耗的 CPU 和内存量。", | ||
| "Request": "请求", | ||
| "Request": "要求", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Find all "Request" entries in zh locale files
rg -n '"Request"' --glob '**/zh/*.json' -A 1 -B 1Repository: openshift/console
Length of output: 868
🏁 Script executed:
# Check the full context around line 360 in the devconsole.json file
sed -n '355,365p' frontend/packages/dev-console/locales/zh/devconsole.jsonRepository: openshift/console
Length of output: 855
🏁 Script executed:
# Search for related resource request/limit terminology in zh files
rg -i 'request|limit|CPU|memory' frontend/packages/dev-console/locales/zh/devconsole.json | head -30Repository: openshift/console
Length of output: 3522
Revert "Request" translation to "请求" for resource request terminology.
The translation at line 360 uses "要求" (requirement/demand), but Kubernetes resource requests consistently use "请求" throughout the console codebase—see the HorizontalPodAutoscaler messages and resource constraint help text. "请求" is the standard technical term in Kubernetes Chinese documentation. Revert to maintain terminology consistency and clarity for Chinese users.
🤖 Prompt for AI Agents
In `@frontend/packages/dev-console/locales/zh/devconsole.json` at line 360, The
translation for the JSON key "Request" currently uses "要求" which is inconsistent
with Kubernetes terminology; update the value for the "Request" key in the
devconsole.json locale entry to "请求" so it matches other console messages (e.g.,
HPA and resource constraint help text) and maintains consistent Chinese
technical terminology.
| "Create Event Source": "Crear fuente de evento", | ||
| "Support": "Soporte", | ||
| "Subscribe": "Suscribirse a", | ||
| "Subscribe": "Suscribir", |
There was a problem hiding this comment.
Use the reflexive form for the user action "Subscribe".
Line 105 reads as a transitive verb; for a user action button, Spanish typically uses “Suscribirse”.
✏️ Proposed fix
- "Subscribe": "Suscribir",
+ "Subscribe": "Suscribirse",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Subscribe": "Suscribir", | |
| "Subscribe": "Suscribirse", |
🤖 Prompt for AI Agents
In `@frontend/packages/knative-plugin/locales/es/knative-plugin.json` at line 105,
The Spanish translation for the "Subscribe" action should be reflexive; update
the JSON entry with key "Subscribe" in knative-plugin.json so its value becomes
"Suscribirse" instead of "Suscribir" to reflect the proper user-action phrasing.
| "VolumeAttributesClass modification failed": "Error en la modificación de VolumeAttributesClass", | ||
| "VolumeAttributesClass modification failed. Your volume settings could not be updated. Please try again.": "Error al modificar VolumeAttributesClass. No se pudo actualizar la configuración del volumen. Inténtalo de nuevo.", | ||
| "VolumeAttributesClass application pending": "Solicitud de VolumeAttributesClass pendiente", | ||
| "VolumeAttributesClass modification in progress": "Modificación de VolumeAttributesClass en curso", | ||
| "VolumeAttributesClass \"{{target}}\" is pending application.": "Clase de atributos de volumen \"{{target}} \" está pendiente de solicitud.", | ||
| "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "La configuración de volumen se está actualizando desde \"{{current}} \" a \"{{target}} \". Esto puede tardar unos instantes.", |
There was a problem hiding this comment.
Remove trailing spaces inside placeholders.
Lines 1136–1137 include extra spaces within {{target}}/{{current}}, which will render in the UI.
✏️ Suggested fix
- "VolumeAttributesClass \"{{target}}\" is pending application.": "Clase de atributos de volumen \"{{target}} \" está pendiente de solicitud.",
- "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "La configuración de volumen se está actualizando desde \"{{current}} \" a \"{{target}} \". Esto puede tardar unos instantes.",
+ "VolumeAttributesClass \"{{target}}\" is pending application.": "Clase de atributos de volumen \"{{target}}\" está pendiente de solicitud.",
+ "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "La configuración de volumen se está actualizando desde \"{{current}}\" a \"{{target}}\". Esto puede tardar unos instantes.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "VolumeAttributesClass modification failed": "Error en la modificación de VolumeAttributesClass", | |
| "VolumeAttributesClass modification failed. Your volume settings could not be updated. Please try again.": "Error al modificar VolumeAttributesClass. No se pudo actualizar la configuración del volumen. Inténtalo de nuevo.", | |
| "VolumeAttributesClass application pending": "Solicitud de VolumeAttributesClass pendiente", | |
| "VolumeAttributesClass modification in progress": "Modificación de VolumeAttributesClass en curso", | |
| "VolumeAttributesClass \"{{target}}\" is pending application.": "Clase de atributos de volumen \"{{target}} \" está pendiente de solicitud.", | |
| "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "La configuración de volumen se está actualizando desde \"{{current}} \" a \"{{target}} \". Esto puede tardar unos instantes.", | |
| "VolumeAttributesClass modification failed": "Error en la modificación de VolumeAttributesClass", | |
| "VolumeAttributesClass modification failed. Your volume settings could not be updated. Please try again.": "Error al modificar VolumeAttributesClass. No se pudo actualizar la configuración del volumen. Inténtalo de nuevo.", | |
| "VolumeAttributesClass application pending": "Solicitud de VolumeAttributesClass pendiente", | |
| "VolumeAttributesClass modification in progress": "Modificación de VolumeAttributesClass en curso", | |
| "VolumeAttributesClass \"{{target}}\" is pending application.": "Clase de atributos de volumen \"{{target}}\" está pendiente de solicitud.", | |
| "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "La configuración de volumen se está actualizando desde \"{{current}}\" a \"{{target}}\". Esto puede tardar unos instantes.", |
🤖 Prompt for AI Agents
In `@frontend/public/locales/es/public.json` around lines 1132 - 1137, Remove the
extra spaces inside the i18n placeholders for the two Spanish entries so
placeholders render without stray spaces: fix the value for the key matching
VolumeAttributesClass \"{{target}}\" is pending application. (currently contains
\"{{target}} \" ) and the value for the key matching Your volume settings are
being updated from \"{{current}}\" to \"{{target}}\". This may take a few
moments. (currently contains \"{{current}} \" and \"{{target}} \") — ensure
placeholders are exactly {{current}} and {{target}} with no internal trailing
spaces.
| "Access modes": "Modos de acceso", | ||
| "Volume mode": "Modo de volumen", | ||
| "StorageClasses": "StorageClasses", | ||
| "Requested VolumeAttributesClass": "Clase de atributos de volumen solicitados", |
There was a problem hiding this comment.
Fix number/gender agreement in Spanish translation.
“Clase … solicitados” should be singular feminine.
✏️ Suggested fix
- "Requested VolumeAttributesClass": "Clase de atributos de volumen solicitados",
+ "Requested VolumeAttributesClass": "Clase de atributos de volumen solicitada",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Requested VolumeAttributesClass": "Clase de atributos de volumen solicitados", | |
| "Requested VolumeAttributesClass": "Clase de atributos de volumen solicitada", |
🤖 Prompt for AI Agents
In `@frontend/public/locales/es/public.json` at line 1146, The Spanish translation
for the JSON key "Requested VolumeAttributesClass" uses a masculine plural
adjective ("solicitados") but needs to be feminine singular; update the value to
the correct agreement, e.g., change it to "Clase de atributos de volumen
solicitada" so the adjective matches the singular feminine noun "Clase".
| "VolumeAttributesClass modification failed": "La modification de la classe VolumeAttributes a échoué", | ||
| "VolumeAttributesClass modification failed. Your volume settings could not be updated. Please try again.": "La modification de la classe VolumeAttributes a échoué. Vos paramètres de volume n'ont pas pu être mis à jour. Veuillez réessayer.", | ||
| "VolumeAttributesClass application pending": "Application VolumeAttributesClass en attente", | ||
| "VolumeAttributesClass modification in progress": "Modification de la classe VolumeAttributes en cours", | ||
| "VolumeAttributesClass \"{{target}}\" is pending application.": "Classe d'attributs de volume \"{{target}}\" est en attente de demande.", | ||
| "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "Vos paramètres de volume sont en cours de mise à jour à partir de \"{{current}}\" to \"{{target}}\". Cela peut prendre quelques instants.", |
There was a problem hiding this comment.
Fix leftover English in French sentence.
Line 1137 includes “to” which is user-visible and breaks the French translation.
✏️ Suggested fix
- "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "Vos paramètres de volume sont en cours de mise à jour à partir de \"{{current}}\" to \"{{target}}\". Cela peut prendre quelques instants.",
+ "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "Vos paramètres de volume sont en cours de mise à jour à partir de \"{{current}}\" vers \"{{target}}\". Cela peut prendre quelques instants.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "VolumeAttributesClass modification failed": "La modification de la classe VolumeAttributes a échoué", | |
| "VolumeAttributesClass modification failed. Your volume settings could not be updated. Please try again.": "La modification de la classe VolumeAttributes a échoué. Vos paramètres de volume n'ont pas pu être mis à jour. Veuillez réessayer.", | |
| "VolumeAttributesClass application pending": "Application VolumeAttributesClass en attente", | |
| "VolumeAttributesClass modification in progress": "Modification de la classe VolumeAttributes en cours", | |
| "VolumeAttributesClass \"{{target}}\" is pending application.": "Classe d'attributs de volume \"{{target}}\" est en attente de demande.", | |
| "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "Vos paramètres de volume sont en cours de mise à jour à partir de \"{{current}}\" to \"{{target}}\". Cela peut prendre quelques instants.", | |
| "VolumeAttributesClass modification failed": "La modification de la classe VolumeAttributes a échoué", | |
| "VolumeAttributesClass modification failed. Your volume settings could not be updated. Please try again.": "La modification de la classe VolumeAttributes a échoué. Vos paramètres de volume n'ont pas pu être mis à jour. Veuillez réessayer.", | |
| "VolumeAttributesClass application pending": "Application VolumeAttributesClass en attente", | |
| "VolumeAttributesClass modification in progress": "Modification de la classe VolumeAttributes en cours", | |
| "VolumeAttributesClass \"{{target}}\" is pending application.": "Classe d'attributs de volume \"{{target}}\" est en attente de demande.", | |
| "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "Vos paramètres de volume sont en cours de mise à jour à partir de \"{{current}}\" vers \"{{target}}\". Cela peut prendre quelques instants.", |
🤖 Prompt for AI Agents
In `@frontend/public/locales/fr/public.json` around lines 1132 - 1137, The French
translation for the key "Your volume settings are being updated from
\"{{current}}\" to \"{{target}}\". This may take a few moments." still contains
the English word "to"; update the value to use correct French wording, e.g.
replace "to" with "à" or "vers" so it reads: "Vos paramètres de volume sont en
cours de mise à jour à partir de \"{{current}}\" à \"{{target}}\". Cela peut
prendre quelques instants." Ensure you update the exact JSON value for that key
("Your volume settings are being updated from \"{{current}}\" to \"{{target}}\".
This may take a few moments.") in frontend/public/locales/fr/public.json.
| "Access modes": "Modes d’accès", | ||
| "Volume mode": "Mode Volume", | ||
| "StorageClasses": "StorageClasses", | ||
| "Requested VolumeAttributesClass": "Classe d'attributs de volume demandé", |
There was a problem hiding this comment.
Fix gender agreement in French translation.
“Classe … demandé” should be feminine to match “classe”.
✏️ Suggested fix
- "Requested VolumeAttributesClass": "Classe d'attributs de volume demandé",
+ "Requested VolumeAttributesClass": "Classe d'attributs de volume demandée",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Requested VolumeAttributesClass": "Classe d'attributs de volume demandé", | |
| "Requested VolumeAttributesClass": "Classe d'attributs de volume demandée", |
🤖 Prompt for AI Agents
In `@frontend/public/locales/fr/public.json` at line 1146, The French translation
for the key "Requested VolumeAttributesClass" has incorrect gender agreement:
change the value string from "Classe d'attributs de volume demandé" to use the
feminine past participle ("demandée") so it reads "Classe d'attributs de volume
demandée" to agree with "Classe".
| "VolumeAttributesClass modification failed": "VolumeAttributesClass の変更に失敗しました", | ||
| "VolumeAttributesClass modification failed. Your volume settings could not be updated. Please try again.": "VolumeAttributesClass の変更に失敗しました。ボリューム設定を更新できませんでした。再試行してください。", | ||
| "VolumeAttributesClass application pending": "VolumeAttributesClass の適用が保留されています", | ||
| "VolumeAttributesClass modification in progress": "VolumeAttributesClass の変更が進行中です", | ||
| "VolumeAttributesClass \"{{target}}\" is pending application.": "VolumeAttributesClass \"{{target}}\" が適用を保留しています。", | ||
| "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "音量設定を \"{{current}}\" から \"{{target}}\" に更新しています。これには数分かかる場合があります。", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's examine the full context of the localization file around the flagged lines
head -n 1150 frontend/public/locales/ja/public.json | tail -n 30Repository: openshift/console
Length of output: 1737
🏁 Script executed:
# Search for other instances of "ボリューム" (storage volume) in the Japanese localization
rg "ボリューム" frontend/public/locales/ja/public.jsonRepository: openshift/console
Length of output: 2721
🏁 Script executed:
# Search for "音量" (audio volume) to see if it's used elsewhere
rg "音量" frontend/public/locales/ja/public.jsonRepository: openshift/console
Length of output: 243
🏁 Script executed:
# Search for "VolumeAttributesClass" context in the file
rg -A 2 -B 2 "VolumeAttributesClass" frontend/public/locales/ja/public.jsonRepository: openshift/console
Length of output: 2150
Fix mistranslation in VolumeAttributesClass update message
Line 1137 uses 音量設定 (audio volume settings) but should use ボリューム設定 (storage volume settings). The inconsistency is clear—line 1134 correctly translates the same concept as ボリューム設定 in storage context. 音量 doesn't appear anywhere else in the localization file and doesn't fit the VolumeAttributesClass domain.
🔧 Fix
- "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "音量設定を \"{{current}}\" から \"{{target}}\" に更新しています。これには数分かかる場合があります。",
+ "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "ボリューム設定を \"{{current}}\" から \"{{target}}\" に更新しています。これには数分かかる場合があります。",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "VolumeAttributesClass modification failed": "VolumeAttributesClass の変更に失敗しました", | |
| "VolumeAttributesClass modification failed. Your volume settings could not be updated. Please try again.": "VolumeAttributesClass の変更に失敗しました。ボリューム設定を更新できませんでした。再試行してください。", | |
| "VolumeAttributesClass application pending": "VolumeAttributesClass の適用が保留されています", | |
| "VolumeAttributesClass modification in progress": "VolumeAttributesClass の変更が進行中です", | |
| "VolumeAttributesClass \"{{target}}\" is pending application.": "VolumeAttributesClass \"{{target}}\" が適用を保留しています。", | |
| "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "音量設定を \"{{current}}\" から \"{{target}}\" に更新しています。これには数分かかる場合があります。", | |
| "VolumeAttributesClass modification failed": "VolumeAttributesClass の変更に失敗しました", | |
| "VolumeAttributesClass modification failed. Your volume settings could not be updated. Please try again.": "VolumeAttributesClass の変更に失敗しました。ボリューム設定を更新できませんでした。再試行してください。", | |
| "VolumeAttributesClass application pending": "VolumeAttributesClass の適用が保留されています", | |
| "VolumeAttributesClass modification in progress": "VolumeAttributesClass の変更が進行中です", | |
| "VolumeAttributesClass \"{{target}}\" is pending application.": "VolumeAttributesClass \"{{target}}\" が適用を保留しています。", | |
| "Your volume settings are being updated from \"{{current}}\" to \"{{target}}\". This may take a few moments.": "ボリューム設定を \"{{current}}\" から \"{{target}}\" に更新しています。これには数分かかる場合があります。", |
🤖 Prompt for AI Agents
In `@frontend/public/locales/ja/public.json` around lines 1132 - 1137, The
translation for the key "Your volume settings are being updated from
\"{{current}}\" to \"{{target}}\". This may take a few moments." uses 音量設定
(audio volume) instead of the correct storage term ボリューム設定 — update that
Japanese string to replace 音量設定 with ボリューム設定 so it matches the storage context
and the other entries like "VolumeAttributesClass modification failed" /
"VolumeAttributesClass の変更に失敗しました".
| "Bound": "バウンド", | ||
| "Lost": "消失", | ||
| "PersistentVolumeClaims": "PersistentVolumeClaims", | ||
| "No claim": "要求がありません", | ||
| "Claim": "要求", | ||
| "Claim": "請求", |
There was a problem hiding this comment.
Terminology check for “Claim”.
Line 1153 uses “請求”, which is billing-oriented. In K8s storage context, “クレーム” (or keeping “Claim”) is more idiomatic. Please confirm with the localization reviewer.
🔧 Suggested tweak
- "Claim": "請求",
+ "Claim": "クレーム",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Bound": "バウンド", | |
| "Lost": "消失", | |
| "PersistentVolumeClaims": "PersistentVolumeClaims", | |
| "No claim": "要求がありません", | |
| "Claim": "要求", | |
| "Claim": "請求", | |
| "Bound": "バウンド", | |
| "Lost": "消失", | |
| "PersistentVolumeClaims": "PersistentVolumeClaims", | |
| "No claim": "要求がありません", | |
| "Claim": "クレーム", |
🤖 Prompt for AI Agents
In `@frontend/public/locales/ja/public.json` around lines 1149 - 1153, The
translation for the JSON key "Claim" currently uses the billing-oriented term
"請求"; update this to the Kubernetes-appropriate term (e.g., "クレーム" or keep
"Claim") and confirm with the localization reviewer; specifically change the
value for the "Claim" key (near "PersistentVolumeClaims" and "No claim") to the
agreed term and ensure consistency with other storage-related keys like
"PersistentVolumeClaims".
| "SubPath": "子路径", | ||
| "Permissions": "权限", | ||
| "Utilized by": "利用", | ||
| "Utilized by": "被利用", |
There was a problem hiding this comment.
“Utilized by” translation is awkward/negative.
Line 1570 “被利用” has a negative connotation. For UI labels, “使用者” or “被…使用” is more natural.
✏️ Proposed fix
- "Utilized by": "被利用",
+ "Utilized by": "使用者",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Utilized by": "被利用", | |
| "Utilized by": "使用者", |
🤖 Prompt for AI Agents
In `@frontend/public/locales/zh/public.json` at line 1570, Replace the awkward
translation for the "Utilized by" key (currently "被利用") with a more natural UI
label; update the JSON entry's value to "使用者" (or "被使用" if context expects
passive phrasing) so the key "Utilized by" reads naturally in Chinese.
jhadvig
left a comment
jhadvig
left a comment
There was a problem hiding this comment.
One comments, but good to go 👍
/lgtm
| { | ||
| "Core platform": "コアプラットフォーム", | ||
| "PodDisruptionBudget": "PodDisruptionBudget", | ||
| "PodDisruptionBudget": "Pod ディスラプション予算", |
There was a problem hiding this comment.
its odd that the singular is partially translated but plural is not
There was a problem hiding this comment.
Hmm, this looks like a gotcha! Should be revert since Resource Kind should not be translated.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cajieh, jhadvig, krishagarwal278 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified later @yapei |
|
/retest |
openshift-ci-robot
added
verified-later
verified
|
@cajieh: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold Revision 3788713 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test e2e-gcp-console |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold Revision 3788713 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@cajieh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@cajieh: Jira Issue OCPBUGS-73871: All pull requests linked via external trackers have merged: This pull request has the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.21 |
|
@cajieh: new pull request created: #16006 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
Description: This PR adds the missing translations for version 4.21.
Adding latest translations from Memsource project https://cloud.memsource.com/web/project2/show/BR9Gy6Rw7ZXW0Ok5ljAW91
Summary by CodeRabbit
Localization Updates