Numpy Datatype: Enable np.dtype() type conversions#1856
Open
franzpoeschel wants to merge 9 commits intoopenPMD:devfrom
Open
Numpy Datatype: Enable np.dtype() type conversions#1856franzpoeschel wants to merge 9 commits intoopenPMD:devfrom
franzpoeschel wants to merge 9 commits intoopenPMD:devfrom
Conversation
1 task
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
franzpoeschel
force-pushed
the
dataset-constructor-conversions
branch
from
eb75a66 to
3d996b7
Compare
franzpoeschel
force-pushed
the
dataset-constructor-conversions
branch
from
3d996b7 to
a4c6bf9
Compare
ax3l
reviewed
Mar 3, 2026
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
ax3l
reviewed
Mar 3, 2026
Comment on lines
+123
to
+127
| try | ||
| { | ||
| create_dtype = numpy.attr("dtype"); | ||
| } | ||
| catch (std::exception const &e) |
Member
There was a problem hiding this comment.
Maybe check if it has the attribute and then throw? Avoids one catch
Contributor
Author
There was a problem hiding this comment.
I have removed those try-catch blocks which should only throw if the numpy interfaces change. This leaves those two blocks that check if numpy is installed and for any errors when calling numpy.dtype() with user-supplied objects.
franzpoeschel
commented
Mar 3, 2026
franzpoeschel
commented
Mar 3, 2026
franzpoeschel
force-pushed
the
dataset-constructor-conversions
branch
from
752d517 to
6c346d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to use things like
np.int_or"double"in theDatasetconstructor, which currently has to be written asnp.dtype(np.int_)andnp.dtype("double"). Check also examples and tests.Affects
Datatype()constructor as well asRecordComponent.make_empty().Future: Derive Dataset definition from Numpy array directly