Harmonize Datatype equality checks#1854
Merged
franzpoeschel merged 13 commits intoopenPMD:devfrom Mar 4, 2026
Merged
Conversation
franzpoeschel
force-pushed
the
fix-datatype-equality
branch
from
dae3b6b to
1ed5125
Compare
franzpoeschel
force-pushed
the
fix-datatype-equality
branch
from
1ed5125 to
2268c24
Compare
franzpoeschel
commented
Mar 3, 2026
| !isSameFloatingPoint<T>(getDatatype()) && | ||
| !isSameComplexFloatingPoint<T>(getDatatype()) && | ||
| !isSameChar<T>(getDatatype())) | ||
| if (dtype != getDatatype()) |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| if (dtype != getDatatype()) | |
| if (!isSame(dtype, getDatatype())) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently
We override
operator==(Datatype, Datatype)such that it checks Datatype equality by representation on the platform. However, in some places, ourloadChunk/storeChunkAPI still manually implements this check, with slight implementation differences.with this pr
This PR merges those differences into the
operator==()implementation and uses that consistently.Also:
Adds a missing type check for store_chunk / load_chunk in our Python API
Adds non-template type comparison operators
Maybe add a further overload to
Datasetconstructor, to avoid this weirdness:EDIT: done separately on Numpy Datatype: Enable np.dtype() type conversions #1856