Skip to content

Adding callback mechanism for Stackable Snackbar #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kartikeyakhanna merged 7 commits into from
Mar 11, 2026
+42 −24
Merged

Adding callback mechanism for Stackable Snackbar #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
306f606
Adding callback mechanism for Stackable Snackbar
Feb 26, 2026
4f6e488
adding callback to model itself
Mar 2, 2026
22e0680
changes in activity
Mar 5, 2026
3a0eddc
copilot suggestions
Mar 5, 2026
f466c87
using derived state to reduce recompositions
Mar 5, 2026
3cb57e7
Merge branch 'master' into pranjal/snackbarIconFix
Mar 9, 2026
6458c9d
conflicts resolution comma
Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions FluentUI.Demo/src/main/java/com/microsoft/fluentuidemo/V2StackableSnackbarActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ fun SnackBarStackDemoLayout(context: V2StackableSnackbarActivity) {
}
}
),
getTrailingIconBasedOnOverflow = {
null
},
onActionTextClicked = {
stackState.toggleExpandedState()
},
Expand Down Expand Up @@ -172,6 +175,9 @@ fun SnackBarStackDemoLayout(context: V2StackableSnackbarActivity) {
}
}
),
getTrailingIconBasedOnOverflow = {
null
},
onActionTextClicked = {
stackState.toggleExpandedState()
},
Expand Down
60 changes: 36 additions & 24 deletions ...fication/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ private val DEFAULT_SNACKBAR_TOKENS = StackableSnackBarTokens()
* @property snackBarToken The tokens for customizing the snackbar's appearance.
* @property onActionTextClicked The callback to be invoked when the action button is clicked.
* @property enableSwipeToDismiss If `true`, swiping the snackbar item horizontally will dismiss it.
* @property getTrailingIconBasedOnOverflow The callback to determine the trailing icon based on whether the text has overflow. It receives a boolean indicating if there is an overflow and returns a FluentIcon to be used as the trailing icon.
*/
@Stable
data class SnackBarItemModel(
Expand All @@ -148,7 +149,8 @@ data class SnackBarItemModel(
val actionText: String? = null,
val snackBarToken: StackableSnackBarTokens = DEFAULT_SNACKBAR_TOKENS,
val onActionTextClicked: () -> Unit = {},
val enableSwipeToDismiss: Boolean = true
val enableSwipeToDismiss: Boolean = true,
val getTrailingIconBasedOnOverflow: (Boolean) -> FluentIcon? = { _ -> trailingIcon }
)

internal data class SnackbarItemInternal(
Expand Down Expand Up @@ -712,6 +714,9 @@ private fun SnackBarStackItem(
.testTag(SnackBarTestTags.SNACK_BAR),
verticalAlignment = Alignment.CenterVertically
) {

var hasTextOverflow by remember { mutableStateOf(false) }
val trailingIcon by remember { derivedStateOf { model.getTrailingIconBasedOnOverflow(hasTextOverflow) ?: model.trailingIcon } }
if (model.leadingIcon != null && model.leadingIcon.isIconAvailable()) {
Box(
modifier = Modifier
Expand Down Expand Up @@ -749,7 +754,12 @@ private fun SnackBarStackItem(
text = model.message,
style = token.titleTypography(snackBarInfo),
maxLines = messageMaxLines,
overflow = TextOverflow.Ellipsis
overflow = TextOverflow.Ellipsis,
onTextLayout = { textLayout ->
if (hasTextOverflow != textLayout.hasVisualOverflow) {
hasTextOverflow = textLayout.hasVisualOverflow
}
}
)
if (!model.subTitle.isNullOrBlank()) {
Text(
Expand Down Expand Up @@ -789,29 +799,31 @@ private fun SnackBarStackItem(
)
}

if (model.trailingIcon != null && model.trailingIcon!!.isIconAvailable()) {
Box(
modifier = Modifier
.testTag(SnackBarTestTags.SNACK_BAR_ICON)
.then(
if (model.trailingIcon!!.onClick != null) {
Modifier.clickable(
interactionSource = remember { MutableInteractionSource() },
indication = rememberRipple(),
enabled = true,
role = Role.Image,
onClick = model.trailingIcon!!.onClick!!
)
} else Modifier
)
) {
Icon(
model.trailingIcon!!,
trailingIcon?.let { icon ->
if (icon.isIconAvailable()) {
Box(
modifier = Modifier
.padding(top = 12.dp, bottom = 12.dp, end = 16.dp)
.size(token.leftIconSize(snackBarInfo)),
tint = token.iconColor(snackBarInfo)
)
.testTag(SnackBarTestTags.SNACK_BAR_ICON)
.then(
icon.onClick?.let { onClick ->
Modifier.clickable(
interactionSource = remember { MutableInteractionSource() },
indication = rememberRipple(),
enabled = true,
role = Role.Image,
onClick = onClick
)
} ?: Modifier
)
) {
Icon(
icon,
modifier = Modifier
.padding(top = 12.dp, bottom = 12.dp, end = 16.dp)
.size(token.leftIconSize(snackBarInfo)),
tint = token.iconColor(snackBarInfo)
)
}
}
}
}
Expand Down
Loading