Adding callback mechanism for Stackable Snackbar#820
Open
pranjal-glowingstar wants to merge 7 commits intomicrosoft:masterfrom
Open
Adding callback mechanism for Stackable Snackbar#820pranjal-glowingstar wants to merge 7 commits intomicrosoft:masterfrom
pranjal-glowingstar wants to merge 7 commits intomicrosoft:masterfrom
Conversation
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a callback-based mechanism in the stackable Snackbar component to allow the trailing icon to be selected dynamically based on whether the message text is visually truncated.
Changes:
- Added a
getTrailingIconBasedOnOverflowcallback toSnackBarItemModeland wired it viaText(onTextLayout=...)overflow detection. - Updated trailing icon rendering to use a locally computed
trailingIconstate rather than always usingmodel.trailingIcon. - Updated the demo activity to pass the new callback when constructing
SnackBarItemModel.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| fluentui_notification/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt | Adds overflow-based trailing icon callback and updates trailing-icon rendering logic. |
| FluentUI.Demo/src/main/java/com/microsoft/fluentuidemo/V2StackableSnackbarActivity.kt | Updates demo usage to provide the new callback parameter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...otification/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt
Show resolved
Hide resolved
...otification/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt
Outdated
Show resolved
Hide resolved
...otification/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt
Show resolved
Hide resolved
...otification/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt
Outdated
Show resolved
Hide resolved
...otification/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt
Outdated
Show resolved
Hide resolved
added 4 commits
March 5, 2026 10:57
# Conflicts: # fluentui_notification/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem :-
As of now we dont have a way to know if the text is not truncated inside the message container. We will need a callback at the icon level probably with truncation param to decide the correct icon for such cases.
Root cause :-
There is no callback at icon level to determine which Icon to show when text is truncated or not.
Fix :-
Added a callback that will give a boolean to the usecase to tell if the text is truncated or not and would expect a FluentIcon from the usecase and render it accordingly.
Validations :-
Build successful and behaviour is working as expected.
(how the change was tested, including both manual and automated tests)
Screenshots
Pull request checklist
This PR has considered: