Skip to content

refactor(node): bundle set_with_head and set_backfill_thresholds into configure_notifications #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evalir merged 1 commit into from
Mar 5, 2026
+9 −12
Merged

refactor(node): bundle set_with_head and set_backfill_thresholds into configure_notifications #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions crates/node/src/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,7 @@ where
match host_deployment_block {
Some(genesis_block) => {
let exex_head = ExExHead { block: genesis_block.num_hash_slow() };
self.host.notifications.set_with_head(exex_head);
self.set_backfill_thresholds();
self.configure_notifications(exex_head);
return Ok(exex_head);
}
None => {
Expand All @@ -256,8 +255,7 @@ where
match genesis_block {
Some(genesis_block) => {
let exex_head = ExExHead { block: genesis_block.num_hash_slow() };
self.host.notifications.set_with_head(exex_head);
self.set_backfill_thresholds();
self.configure_notifications(exex_head);
return Ok(exex_head);
}
None => panic!("failed to find genesis block"),
Expand All @@ -275,8 +273,7 @@ where
Some(host_block) => {
debug!(host_height, "found host block for height");
let exex_head = ExExHead { block: host_block.num_hash_slow() };
self.host.notifications.set_with_head(exex_head);
self.set_backfill_thresholds();
self.configure_notifications(exex_head);
Ok(exex_head)
}
None => {
Expand All @@ -285,8 +282,7 @@ where
match genesis_block {
Some(genesis_block) => {
let exex_head = ExExHead { block: genesis_block.num_hash_slow() };
self.host.notifications.set_with_head(exex_head);
self.set_backfill_thresholds();
self.configure_notifications(exex_head);
Ok(exex_head)
}
None => panic!("failed to find genesis block"),
Expand All @@ -295,10 +291,11 @@ where
}
}

/// Sets backfill thresholds to limit memory usage during sync.
/// This should be called after `set_with_head` to configure how many
/// blocks can be processed per backfill batch.
fn set_backfill_thresholds(&mut self) {
/// Configures the ExEx notification stream with the given head and
/// backfill thresholds from the node config.
fn configure_notifications(&mut self, exex_head: ExExHead) {
self.host.notifications.set_with_head(exex_head);

let max_blocks = self.config.backfill_max_blocks();
let max_duration = self.config.backfill_max_duration();
self.host.notifications.set_backfill_thresholds(ExecutionStageThresholds {
Expand Down