Conversation
… configure_notifications The two calls were always paired across 4 call sites in set_exex_head. Bundling them into a single helper eliminates the risk of forgetting to pair them when adding new code paths. ENG-1959 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Evalir
changed the title
bundle set_with_head and set_backfill_thresholds into configure_notifications
Fraser999
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_backfill_thresholds→configure_notificationsand added anexex_headparameter that callsset_with_headinternallyset_with_head+set_backfill_thresholdscall sites inset_exex_headwith a singleconfigure_notifications(exex_head)callENG-1959
Test plan
cargo clippy -p signet-node --all-features --all-targetspassescargo +nightly fmtpassescargo t -p signet-node(pending full compilation)🤖 Generated with Claude Code