Refactor: Remove 'in' modifier for small ID structs#85
Merged
Conversation
- Removed `in` modifier from `B2ShapeId`, `B2BodyId`, and `B2ContactId` parameters in various functions and delegates. - These structs are small (8 bytes or less), so passing them by value is more efficient than passing by reference. - This change avoids potential pointer indirection overhead and aligns with C# performance best practices for small structs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inmodifier fromB2ShapeId,B2BodyId, andB2ContactIdparameters in various functions and delegates.