Skip to content

fix: use proper exception objects instead of bare raise/assert strings #13398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ricardo-M-L wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix: use proper exception objects instead of bare raise/assert strings #13398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/diffusers/models/attention_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,11 +325,11 @@ def set_use_xla_flash_attention(
"""
if use_xla_flash_attention:
if not is_torch_xla_available:
raise "torch_xla is not available"
raise RuntimeError("torch_xla is not available")
elif is_torch_xla_version("<", "2.3"):
raise "flash attention pallas kernel is supported from torch_xla version 2.3"
raise RuntimeError("flash attention pallas kernel is supported from torch_xla version 2.3")
elif is_spmd() and is_torch_xla_version("<", "2.4"):
raise "flash attention pallas kernel using SPMD is supported from torch_xla version 2.4"
raise RuntimeError("flash attention pallas kernel using SPMD is supported from torch_xla version 2.4")
else:
if is_flux:
processor = XLAFluxFlashAttnProcessor2_0(partition_spec)
Expand Down
2 changes: 1 addition & 1 deletion src/diffusers/pipelines/controlnet_sd3/pipeline_stable_diffusion_3_controlnet_inpainting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1262,7 +1262,7 @@ def __call__(

control_image = control_images
else:
assert ValueError("Controlnet not found. Please check the controlnet model.")
raise ValueError("Controlnet not found. Please check the controlnet model.")

if controlnet_pooled_projections is None:
controlnet_pooled_projections = torch.zeros_like(pooled_prompt_embeds)
Expand Down