fix: use proper exception objects instead of bare raise/assert strings#13398
Open
Ricardo-M-L wants to merge 1 commit intohuggingface:mainfrom
Open
fix: use proper exception objects instead of bare raise/assert strings#13398Ricardo-M-L wants to merge 1 commit intohuggingface:mainfrom
Ricardo-M-L wants to merge 1 commit intohuggingface:mainfrom
Conversation
- attention_processor.py: `raise "string"` causes TypeError at runtime.
Changed 3 occurrences to `raise RuntimeError("...")`.
- pipeline_stable_diffusion_3_controlnet_inpainting.py:
`assert ValueError("...")` always passes (ValueError object is truthy).
Changed to `raise ValueError("...")`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two types of exception handling bugs:
1.
raise "string"in attention_processor.py (lines 328-332)`raise "string"` causes `TypeError: exceptions must derive from BaseException` at runtime instead of the intended error message. Changed 3 occurrences to `raise RuntimeError("...")`.
2.
assert ValueError("...")in controlnet_inpainting pipeline (line 1265)`assert ValueError("...")` always passes because a ValueError object is truthy. Changed to `raise ValueError("...")`.