Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<junixsocket.version>2.10.1</junixsocket.version>
<opentelemetry.version>1.59.0</opentelemetry.version>
<opentelemetry.version>1.60.0</opentelemetry.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this version update is correct, it highlights an underlying issue with how OpenTelemetry dependencies are managed in this pom.xml.

Some dependencies like opentelemetry-api (line 43) inherit their version from parent POMs, while others like opentelemetry-sdk (line 67) use this explicit ${opentelemetry.version} property. This can lead to a mix of different OpenTelemetry versions on the classpath, potentially causing runtime errors like NoSuchMethodError.

To ensure version consistency, I recommend using the OpenTelemetry BOM to manage all io.opentelemetry dependencies. You can do this by adding the BOM to a <dependencyManagement> section and removing the explicit <version> tags from individual dependencies.

Example of importing the BOM:

<dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>io.opentelemetry</groupId>
      <artifactId>opentelemetry-bom</artifactId>
      <version>${opentelemetry.version}</version>
      <type>pom</type>
      <scope>import</scope>
    </dependency>
  </dependencies>
</dependencyManagement>

This will ensure all OpenTelemetry artifacts are on the same version and will simplify future updates.

<google.cloud.monitoring.version>3.85.0</google.cloud.monitoring.version>
</properties>

Expand Down