deps: update opentelemetry.version to v1.60.0#4379
deps: update opentelemetry.version to v1.60.0#4379renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
/gcbrun |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the OpenTelemetry dependency version to Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR, generated by Renovate, updates the opentelemetry.version property in benchmarks/pom.xml to 1.60.0. While this update itself seems fine and the breaking changes in this OpenTelemetry version are unlikely to affect this project, I've noticed a potential issue with how OpenTelemetry dependencies are managed in this module. There's a risk of version mismatch between different OpenTelemetry artifacts, which could lead to runtime issues. I've added a comment with a suggestion to improve this by using the OpenTelemetry BOM for consistent version management.
Note: Security Review has been skipped due to the limited scope of the PR.
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
| <junixsocket.version>2.10.1</junixsocket.version> | ||
| <opentelemetry.version>1.59.0</opentelemetry.version> | ||
| <opentelemetry.version>1.60.0</opentelemetry.version> |
There was a problem hiding this comment.
While this version update is correct, it highlights an underlying issue with how OpenTelemetry dependencies are managed in this pom.xml.
Some dependencies like opentelemetry-api (line 43) inherit their version from parent POMs, while others like opentelemetry-sdk (line 67) use this explicit ${opentelemetry.version} property. This can lead to a mix of different OpenTelemetry versions on the classpath, potentially causing runtime errors like NoSuchMethodError.
To ensure version consistency, I recommend using the OpenTelemetry BOM to manage all io.opentelemetry dependencies. You can do this by adding the BOM to a <dependencyManagement> section and removing the explicit <version> tags from individual dependencies.
Example of importing the BOM:
<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-bom</artifactId>
<version>${opentelemetry.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>This will ensure all OpenTelemetry artifacts are on the same version and will simplify future updates.
This PR contains the following updates:
1.59.0→1.60.01.59.0→1.60.01.59.0→1.60.01.59.0→1.60.0Release Notes
open-telemetry/opentelemetry-java (io.opentelemetry:opentelemetry-sdk-testing)
v1.60.0API
(#8012)
SpanBuilder.setAttributeallows null values(#8072)
Incubating
(#8074)
ExtendedAttributes,ExtendedAttributeKey,ExtendedAttributeType,ExtendedAttributesBuilder(#8060)
peerServiceMappingaccessor fromInstrumentationConfigUtil(#8088)
SDK
Traces
TraceIdRatioBasedSampleras root sampler(#8065)
(#7993)
(#8096)
(#8145)
Metrics
(#8015)
PeriodicMetricReader(#8038)
(#8095)
otel.experimental.metrics.cardinality.limitproperty(#8124)
GlobUtilandIncludePatternMatching, used in views and declarativeconfig matching, previously were inconsistent in case sensitivity. If a glob char (* or ?) was
present, it was evaluated with case sensitivity. If no glob chars were present, it was evaluated
with case insensitivity. Now, all are consistently evaluated with case sensitivity.
(#8152)
Logs
LogRecordBuilder.setException(#8089)
setTimestampjavadoc for event timestamp behavior(#8104)
Exporters
(#8014)
(#8080)
(#8107)
KeyManagerFactory.getDefaultAlgorithm()inTlsUtil.keyManager()(#8122)
(#8147)
Extensions
(#8059)
(#8123)
(#8028)
(#8069)
DeclarativeConfigContext(#8070)
(#8073)
(#8081)
(#8045)
(#8133)
(#8037)
(#8046)
(#8075)
(#8090)
Project tooling
(#6978)
(#8061)
(#8078)
(#8083)
(#8031)
LogRecordBenchmark(#8106,
#8117)
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.