Skip to content

Fix(CI): Ignore folder path fix for typescript 3.8 test #5720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucas-zimerman wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Fix(CI): Ignore folder path fix for typescript 3.8 test #5720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c6f8803
test pure
lucas-zimerman Feb 25, 2026
8fd83e5
relink rn after yarn install
lucas-zimerman Feb 25, 2026
3ead4fa
fix yalc install
lucas-zimerman Feb 25, 2026
45d7c6a
test disable security patches
lucas-zimerman Feb 25, 2026
f2203da
keep original resolutions
lucas-zimerman Feb 25, 2026
c1d6e07
debug output bundle
lucas-zimerman Feb 25, 2026
b602723
extra debug data
lucas-zimerman Feb 25, 2026
94843e3
extra fields for npmignore/ remove debug logs.
lucas-zimerman Feb 25, 2026
43ca936
Apply suggestions from code review
lucas-zimerman Feb 25, 2026
8d4bb98
Update .github/workflows/buildandtest.yml
lucas-zimerman Feb 25, 2026
4c6a765
Update dev-packages/type-check/run-type-check.sh
lucas-zimerman Feb 25, 2026
4d03925
rollback changes & remove uneeded gitignore
lucas-zimerman Feb 25, 2026
bb829d2
Merge branch 'lz/fiz-ts38' of https://github.com/getsentry/sentry-rea…
lucas-zimerman Feb 25, 2026
5f23068
add back dist/ ts to ignore list
lucas-zimerman Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/buildandtest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ jobs:
name: ts3.8
path: packages/core/ts3.8
- name: Install Global Dependencies
run: npm i -g add yalc
Copy link
Collaborator Author

@lucas-zimerman lucas-zimerman Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mixed yarn syntax, npm was trying to install a package called add, and yalc.

run: npm i -g yalc
- name: Type Check
working-directory: dev-packages/type-check
run: yarn type-check
Expand Down
4 changes: 4 additions & 0 deletions dev-packages/type-check/run-type-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,14 @@ yalc publish

cd "${__dirpath}/ts3.8-test"

# Add yalc package (creates .yalc/ directory and updates package.json)
yalc add @sentry/react-native

yarn install

# Re-add yalc package to ensure it's in node_modules (yarn might have removed it)
yalc add @sentry/react-native

echo "Removing duplicate React types..."
rm -rf ./node_modules/@types/react-native/node_modules/@types/react

Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@
"performance-tests/TestAppPlain",
"performance-tests/TestAppSentry"
],
"//": [
"Appium has a dependency on @xmldom/xmldom@^0.x, which causes chromedrive build to fail yarn install",
"See: https://github.com/appium/appium-chromedriver/pull/424"
],
"volta": {
"node": "18.20.8",
"yarn": "3.6.4"
},
"//": [
"Appium has a dependency on @xmldom/xmldom@^0.x, which causes chromedrive build to fail yarn install",
"See: https://github.com/appium/appium-chromedriver/pull/424"
],
"resolutions": {
"appium-chromedriver@npm:5.6.73/@xmldom/xmldom": "0.8.10",
"fast-xml-parser": "^5.3.6",
Expand Down
2 changes: 2 additions & 0 deletions packages/core/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
!LICENSE.md
!CHANGELOG.md
!README.md
!/dist/
!/ts3.8/
!/dist/**/*
!ts3.8/**/*
!RNSentry.podspec
Expand Down
Binary file modified packages/core/android/libs/replay-stubs.jar
View file
Open in desktop
Binary file not shown.
20 changes: 14 additions & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20114,14 +20114,22 @@ __metadata:
languageName: node
linkType: hard

"fast-xml-builder@npm:^1.0.0":
version: 1.0.0
resolution: "fast-xml-builder@npm:1.0.0"
checksum: d6fb6d860ebb67c0dbec4c91a5cde3bf3e4cc40407db249539fe0d4e98e5c1bc09b3d45e5cbc412aaee8dd16605467f8c054c104fbccba23cf78ec15ff8767ab
languageName: node
linkType: hard

"fast-xml-parser@npm:^5.3.6":
version: 5.3.7
resolution: "fast-xml-parser@npm:5.3.7"
version: 5.4.1
resolution: "fast-xml-parser@npm:5.4.1"
dependencies:
fast-xml-builder: ^1.0.0
strnum: ^2.1.2
bin:
fxparser: src/cli/cli.js
checksum: 0bb307bc63a01c079ae28b6b62eeea0007d787e6ab47dfca493f40305f78aeedea2906b2632bf0eb9d4d868e748c77c70393a808441fb5949c9d2e6f8f2825f0
checksum: 98b8d2f208dea6be10740509e4ef59dc175584cfb29cb3f82849f0a79645ccaf40916589533029c30b4b47a78e744e8fc08ff468f214a231f450e51f0d8d32c6
languageName: node
linkType: hard

Expand Down Expand Up @@ -32792,15 +32800,15 @@ __metadata:
linkType: hard

"tar@npm:^7.5.7":
version: 7.5.7
resolution: "tar@npm:7.5.7"
version: 7.5.9
resolution: "tar@npm:7.5.9"
dependencies:
"@isaacs/fs-minipass": ^4.0.0
chownr: ^3.0.0
minipass: ^7.1.2
minizlib: ^3.1.0
yallist: ^5.0.0
checksum: 82fa04804b6cae4c0b46b84e97a08c39e1c17bb959350baa32d139bcf5e1fc7ebc3ceb72465dd3e2e311992386ecc13599a257d5672158490ceb9464146d5573
checksum: 26fbbdf536895814167d03e4883f80febb6520729169c54d0f29ee8a163557283862752493f0e5b60800a6f3608aac3250c41fac8e20a4f056ba4fa63f3dbad7
languageName: node
linkType: hard

Expand Down
Loading