Fix(CI): Ignore folder path fix for typescript 3.8 test by lucas-zimerman · Pull Request #5720 · getsentry/sentry-react-native

lucas-zimerman · 2026-02-25T12:03:04Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

The TypeScript 3.8 compatibility check was failing in CI with
"Cannot find module '@sentry/react-native'" because the ts3.8/
directory was not being included by yalc publish.

Root cause: The .npmignore pattern !/ts3.8/**/* only unignores
files inside the directory, but the directory itself was still ignored
by the * rule. This caused npm's pack logic to skip the entire directory.

Fix: Added explicit directory unignore patterns (!/ts3.8/ and !/dist/)
alongside the existing content patterns.

💡 Motivation and Context

Having all CI tests green and non flaky.

💚 How did you test it?

CI, it passes locally.

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2026-02-25T12:03:24Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

Fix(CI): Ignore folder path fix for typescript 3.8 test by lucas-zimerman in #5720

feat(tooling): add Cursor BUGBOT.md review guidelines by antonis in #5716
chore(ci): Use runner group 10 by itaybre in #5717
chore(deps): bump qs to ^6.14.2 by antonis in #5707
chore(deps): bump lodash to ^4.17.23 by antonis in #5702
chore(deps): bump getsentry/craft from 2.21.4 to 2.21.7 by dependabot in #5694
chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.21.4 to 2.21.7 by dependabot in #5695
chore(deps): update CLI to v3.2.2 by github-actions in #5692
chore(deps): bump github/codeql-action from 4.32.3 to 4.32.4 by dependabot in #5693
chore(deps): update Maestro to v2.2.0 by github-actions in #5691
chore(deps): update Cocoa SDK to v9.5.0 by github-actions in #5685
chore(deps): update Android SDK Stubs to v8.33.0 by github-actions in #5697
chore(deps): update Android SDK to v8.33.0 by github-actions in #5684
chore(deps): update Sentry Android Gradle Plugin to v6.1.0 by github-actions in #5687
Ref(CI): Add android sdk version check by lucas-zimerman in #5686

_{🤖 This preview updates automatically when you update the PR.}

Co-authored-by: Claude <noreply@anthropic.com>

github-actions · 2026-02-25T13:02:48Z

	Warnings
⚠️	🤖 Replay Stubs Check ✅ No changes detected in replay-stubs.jar All file contents are identical (verified by SHA-256 hash comparison).

Generated by 🚫 dangerJS against 5f23068

github-actions · 2026-02-25T13:31:55Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	411.92 ms	422.14 ms	10.22 ms
Size	43.75 MiB	48.46 MiB	4.71 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`c7f264b`	434.98 ms	452.96 ms	17.98 ms
`9f211e3`	451.50 ms	500.00 ms	48.50 ms
`9ced351`+dirty	405.40 ms	419.39 ms	13.98 ms
`f70acbf`+dirty	373.39 ms	382.81 ms	9.43 ms
`f234eb4`+dirty	407.62 ms	429.64 ms	22.02 ms
`2adbd1e`+dirty	433.98 ms	427.96 ms	-6.02 ms
`7886639`+dirty	425.10 ms	477.73 ms	52.63 ms
`a206511`+dirty	424.28 ms	474.82 ms	50.54 ms
`98f632c`	424.25 ms	435.48 ms	11.23 ms
`46da307`	455.92 ms	443.79 ms	-12.13 ms

App size

Revision	Plain	With Sentry	Diff
`c7f264b`	17.75 MiB	19.68 MiB	1.94 MiB
`9f211e3`	17.75 MiB	19.68 MiB	1.94 MiB
`9ced351`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`f70acbf`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`f234eb4`+dirty	17.75 MiB	19.74 MiB	1.99 MiB
`2adbd1e`+dirty	17.75 MiB	19.70 MiB	1.96 MiB
`7886639`+dirty	43.75 MiB	48.42 MiB	4.67 MiB
`a206511`+dirty	43.75 MiB	48.07 MiB	4.32 MiB
`98f632c`	17.75 MiB	20.15 MiB	2.41 MiB
`46da307`	17.75 MiB	19.68 MiB	1.93 MiB

github-actions · 2026-02-25T13:58:25Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1221.43 ms	1223.66 ms	2.23 ms
Size	3.38 MiB	4.78 MiB	1.40 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	1216.61 ms	1214.15 ms	-2.47 ms
`80e4616`+dirty	1206.90 ms	1205.94 ms	-0.96 ms
`818a608`+dirty	1218.84 ms	1223.18 ms	4.34 ms
`77061ed`+dirty	1210.77 ms	1218.45 ms	7.68 ms
`bef3709`+dirty	1217.79 ms	1225.33 ms	7.54 ms
`a206511`+dirty	1225.02 ms	1223.74 ms	-1.28 ms
`74979ac`+dirty	1212.33 ms	1212.54 ms	0.21 ms
`a2bb688`+dirty	1244.82 ms	1238.60 ms	-6.22 ms
`8a868fe`+dirty	1206.85 ms	1215.04 ms	8.19 ms
`d590428`+dirty	1221.23 ms	1225.27 ms	4.03 ms

App size

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`80e4616`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`818a608`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`77061ed`+dirty	3.19 MiB	4.54 MiB	1.36 MiB
`bef3709`+dirty	3.38 MiB	4.78 MiB	1.40 MiB
`a206511`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`74979ac`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`a2bb688`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`8a868fe`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`d590428`+dirty	3.38 MiB	4.78 MiB	1.39 MiB

github-actions · 2026-02-25T15:48:16Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1224.30 ms	1230.11 ms	5.80 ms
Size	3.38 MiB	4.78 MiB	1.40 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	1229.13 ms	1228.46 ms	-0.67 ms
`80e4616`+dirty	1221.32 ms	1225.64 ms	4.32 ms
`818a608`+dirty	1205.76 ms	1208.00 ms	2.24 ms
`77061ed`+dirty	1233.16 ms	1234.88 ms	1.71 ms
`bef3709`+dirty	1222.07 ms	1220.24 ms	-1.83 ms
`a206511`+dirty	1185.00 ms	1186.35 ms	1.35 ms
`74979ac`+dirty	1210.49 ms	1213.31 ms	2.82 ms
`a2bb688`+dirty	1223.53 ms	1232.90 ms	9.37 ms
`8a868fe`+dirty	1221.50 ms	1230.78 ms	9.28 ms
`d590428`+dirty	1211.77 ms	1220.51 ms	8.75 ms

App size

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`80e4616`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`818a608`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`77061ed`+dirty	2.63 MiB	3.98 MiB	1.34 MiB
`bef3709`+dirty	3.38 MiB	4.78 MiB	1.40 MiB
`a206511`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`74979ac`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`a2bb688`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`8a868fe`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`d590428`+dirty	3.38 MiB	4.78 MiB	1.39 MiB

github-actions · 2026-02-25T16:06:44Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	409.02 ms	436.33 ms	27.31 ms
Size	43.94 MiB	49.33 MiB	5.39 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`664c66f`+dirty	376.23 ms	389.51 ms	13.28 ms
`d73150f`+dirty	424.60 ms	454.35 ms	29.75 ms
`4a17c8f`+dirty	368.54 ms	381.43 ms	12.89 ms
`b3b5b0d`+dirty	361.42 ms	403.90 ms	42.48 ms
`9ced351`+dirty	361.74 ms	411.45 ms	49.70 ms
`7886639`+dirty	530.30 ms	571.34 ms	41.04 ms
`c08359e`+dirty	406.04 ms	428.87 ms	22.83 ms
`3099014`+dirty	344.58 ms	404.21 ms	59.63 ms
`d751a5d`+dirty	341.61 ms	403.06 ms	61.45 ms
`682f0f5`+dirty	402.33 ms	440.61 ms	38.28 ms

App size

Revision	Plain	With Sentry	Diff
`664c66f`+dirty	43.94 MiB	49.38 MiB	5.44 MiB
`d73150f`+dirty	43.94 MiB	49.38 MiB	5.44 MiB
`4a17c8f`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`b3b5b0d`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`9ced351`+dirty	43.94 MiB	49.27 MiB	5.33 MiB
`7886639`+dirty	43.94 MiB	49.28 MiB	5.34 MiB
`c08359e`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`3099014`+dirty	7.15 MiB	8.43 MiB	1.27 MiB
`d751a5d`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`682f0f5`+dirty	43.94 MiB	48.91 MiB	4.97 MiB

Co-authored-by: Claude <noreply@anthropic.com>

.github/workflows/buildandtest.yml

dev-packages/type-check/run-type-check.sh

…ct-native into lz/fiz-ts38

lucas-zimerman · 2026-02-25T18:08:48Z

.github/workflows/buildandtest.yml

          name: ts3.8
          path: packages/core/ts3.8
      - name: Install Global Dependencies
-        run: npm i -g add yalc


mixed yarn syntax, npm was trying to install a package called add, and yalc.

test pure

c6f8803

lucas-zimerman added the ready-to-merge Triggers the full CI test suite label Feb 25, 2026

lucas-zimerman and others added 4 commits February 25, 2026 12:15

relink rn after yarn install

8fd83e5

Co-authored-by: Claude <noreply@anthropic.com>

fix yalc install

3ead4fa

Co-authored-by: Claude <noreply@anthropic.com>

test disable security patches

45d7c6a

keep original resolutions

f2203da

debug output bundle

c1d6e07

lucas-zimerman and others added 2 commits February 25, 2026 16:13

extra debug data

b602723

extra fields for npmignore/ remove debug logs.

94843e3

Co-authored-by: Claude <noreply@anthropic.com>

lucas-zimerman commented Feb 25, 2026

View reviewed changes

.github/workflows/buildandtest.yml Outdated Show resolved Hide resolved

lucas-zimerman commented Feb 25, 2026

View reviewed changes

dev-packages/type-check/run-type-check.sh Outdated Show resolved Hide resolved

lucas-zimerman commented Feb 25, 2026

View reviewed changes

dev-packages/type-check/run-type-check.sh Outdated Show resolved Hide resolved

lucas-zimerman added 6 commits February 25, 2026 16:42

Apply suggestions from code review

43ca936

Update .github/workflows/buildandtest.yml

8d4bb98

Update dev-packages/type-check/run-type-check.sh

4c6a765

rollback changes & remove uneeded gitignore

4d03925

Merge branch 'lz/fiz-ts38' of https://github.com/getsentry/sentry-rea…

bb829d2

…ct-native into lz/fiz-ts38

add back dist/ ts to ignore list

5f23068

lucas-zimerman changed the title ~~Test: TS 3.8 fix~~ Fix(CI): Ignore folder path fix for typescript 3.8 test Feb 25, 2026

lucas-zimerman added skip-changelog labels Feb 25, 2026

lucas-zimerman marked this pull request as ready for review February 25, 2026 18:07

lucas-zimerman requested review from alwx and antonis as code owners February 25, 2026 18:07

lucas-zimerman commented Feb 25, 2026

View reviewed changes

Uh oh!

Conversation

lucas-zimerman commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Replay Stubs Check

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucas-zimerman Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

lucas-zimerman commented Feb 25, 2026 •

edited

Loading

github-actions bot commented Feb 25, 2026 •

edited

Loading

github-actions bot commented Feb 25, 2026 •

edited

Loading

github-actions bot commented Feb 25, 2026 •

edited

Loading

github-actions bot commented Feb 25, 2026 •

edited

Loading

github-actions bot commented Feb 25, 2026 •

edited

Loading

github-actions bot commented Feb 25, 2026 •

edited

Loading