Skip to content

Minor refactoring to rename variables #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zoewangg merged 1 commit into from
Mar 6, 2026

Minor refactoring to rename variables

7278f02
Select commit
Loading
Failed to load commit list.
Merged

Minor refactoring to rename variables #6763

Minor refactoring to rename variables
7278f02
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 5, 2026 in 14m 10s

Quality Gate failed

Failed conditions
64.6% Coverage on New Code (required ≥ 80%)
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 92 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/internal/CrtRequestExecutorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "hasFailedWithThrowableThat"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOvMNYW-c5pE8hH2&open=AZzAZOvMNYW-c5pE8hH2&pullRequest=6763

Check warning on line 74 in http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/AwsCrtHttpClientBase.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "tlsContextOptions" private field. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOxyNYW-c5pE8hIG&open=AZzAZOxyNYW-c5pE8hIG&pullRequest=6763

Check warning on line 40 in http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/CrtRequestExecutor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Throwable. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOw2NYW-c5pE8hIB&open=AZzAZOw2NYW-c5pE8hIB&pullRequest=6763

Check warning on line 123 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/internal/CrtAsyncRequestExecutorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOubNYW-c5pE8hHu&open=AZzAZOubNYW-c5pE8hHu&pullRequest=6763

Check warning on line 101 in test/sdk-benchmarks/src/main/java/software/amazon/awssdk/benchmark/apicall/httpclient/async/NettyHttpClientH2AlpnBenchmark.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to local variable "run". 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOsqNYW-c5pE8hHj&open=AZzAZOsqNYW-c5pE8hHj&pullRequest=6763

Check failure on line 95 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2BehaviorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOtqNYW-c5pE8hHm&open=AZzAZOtqNYW-c5pE8hHm&pullRequest=6763

Check warning on line 65 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2ErrorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOv9NYW-c5pE8hH9&open=AZzAZOv9NYW-c5pE8hH9&pullRequest=6763

Check warning on line 95 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2BehaviorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOtqNYW-c5pE8hHq&open=AZzAZOtqNYW-c5pE8hHq&pullRequest=6763

Check warning on line 97 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/AwsCrtHttpClientSpiVerificationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'executableRequest::call'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOwSNYW-c5pE8hH-&open=AZzAZOwSNYW-c5pE8hH-&pullRequest=6763

Check warning on line 79 in http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/response/InputStreamAdaptingHttpStreamResponseHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'responseHandlerHelper::closeStream'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOwmNYW-c5pE8hIA&open=AZzAZOwmNYW-c5pE8hIA&pullRequest=6763

Check warning on line 76 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2BehaviorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOtqNYW-c5pE8hHo&open=AZzAZOtqNYW-c5pE8hHo&pullRequest=6763

Check warning on line 89 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2BehaviorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOtrNYW-c5pE8hHs&open=AZzAZOtrNYW-c5pE8hHs&pullRequest=6763

Check warning on line 65 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2BehaviorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOtqNYW-c5pE8hHn&open=AZzAZOtqNYW-c5pE8hHn&pullRequest=6763

Check warning on line 142 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/internal/CrtAsyncRequestExecutorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOubNYW-c5pE8hHv&open=AZzAZOubNYW-c5pE8hHv&pullRequest=6763

Check warning on line 100 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2ErrorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOv9NYW-c5pE8hH7&open=AZzAZOv9NYW-c5pE8hH7&pullRequest=6763

Check warning on line 125 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/internal/CrtRequestExecutorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOvMNYW-c5pE8hH0&open=AZzAZOvMNYW-c5pE8hH0&pullRequest=6763

Check warning on line 46 in http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/CrtAsyncRequestExecutor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Throwable. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOxHNYW-c5pE8hIC&open=AZzAZOxHNYW-c5pE8hIC&pullRequest=6763

Check warning on line 69 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2ErrorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOv9NYW-c5pE8hH4&open=AZzAZOv9NYW-c5pE8hH4&pullRequest=6763

Check warning on line 35 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/AwsCrtAsyncHttpClientSpiVerificationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.net.ConnectException'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOvvNYW-c5pE8hH3&open=AZzAZOvvNYW-c5pE8hH3&pullRequest=6763

Check warning on line 85 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2ErrorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOv9NYW-c5pE8hH6&open=AZzAZOv9NYW-c5pE8hH6&pullRequest=6763

Check warning on line 183 in http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/AwsCrtHttpClientBase.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Immediately return this expression instead of assigning it to the temporary variable "connPool". 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOxyNYW-c5pE8hIF&open=AZzAZOxyNYW-c5pE8hIF&pullRequest=6763

Check failure on line 89 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2BehaviorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOtqNYW-c5pE8hHl&open=AZzAZOtqNYW-c5pE8hHl&pullRequest=6763

Check warning on line 89 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2BehaviorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOtqNYW-c5pE8hHp&open=AZzAZOtqNYW-c5pE8hHp&pullRequest=6763

Check warning on line 120 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/AwsCrtHttpClientSpiVerificationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'executableRequest::call'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOwSNYW-c5pE8hH_&open=AZzAZOwSNYW-c5pE8hH_&pullRequest=6763

Check warning on line 60 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2BehaviorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzAZOtqNYW-c5pE8hHr&open=AZzAZOtqNYW-c5pE8hHr&pullRequest=6763
View more details on SonarQubeCloud