Minor refactoring to rename variables#6763
Merged
zoewangg merged 1 commit intofeature/master/crtH2from Mar 6, 2026
Merged
Conversation
|
RanVaknin
reviewed
Mar 6, 2026
| } | ||
|
|
||
| @Test | ||
| public void tcpConnectFailure_shouldThrowIOException() throws Exception { |
Contributor
There was a problem hiding this comment.
Seems like this is related to the rest of the PR? What is it for?
Contributor
Author
There was a problem hiding this comment.
Should've mentioned this in the description 😅 added a new test to cover the testing gap in h2
RanVaknin
approved these changes
Mar 6, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.