#1018 [bug] Fix brief input error display before screen transition#1074
Open
github-actions[bot] wants to merge 1 commit intodevelopfrom
Open
#1018 [bug] Fix brief input error display before screen transition#1074github-actions[bot] wants to merge 1 commit intodevelopfrom
github-actions[bot] wants to merge 1 commit intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1018
Screen:
searchpwComponent:
inputChanges:
The issue states that the input field briefly shows an error state before screen transition. This is likely due to a timing issue where the error state is set and then immediately cleared when the screen navigates. To fix this, the error state should be managed in a way that it's properly cleared after the navigation or not shown if navigation is imminent. Without more context on how the error state is managed, a common approach is to ensure error messages are cleared before navigation. Assuming
WriteScreen.ktis the relevant file for the search input, we'll assume theWriteViewModelhandles the state and add logic to clear any pending error states before navigating.Files modified:
presentation/src/main/java/daily/dayo/presentation/screen/write/WriteScreen.kt