Introduce diagnostic variables for CABLE outputs#688
Merged
SeanBryan51 merged 2 commits intomainfrom Mar 5, 2026
Merged
Conversation
5 tasks
SeanBryan51
force-pushed
the
cable-output-introduce-diagnostic-variables-for-cable-outputs
branch
4 times, most recently
from
799344b to
43c565b
Compare
SeanBryan51
commented
Feb 26, 2026
SeanBryan51
force-pushed
the
cable-output-introduce-diagnostic-variables-for-cable-outputs
branch
2 times, most recently
from
7edfb5a to
d9d1179
Compare
SeanBryan51
force-pushed
the
cable-output-introduce-diagnostic-variables-for-cable-outputs
branch
from
d9d1179 to
80390f7
Compare
Collaborator
Author
|
Bitwise comparisons have been tested manually with the following script, allowing for an absolute tolerance of #!/bin/bash
module load nccmp
set -ex
for f in runs/fluxsite/outputs/*R0*.nc; do
nccmp -d -x Rnet -x RadT ${f/R0/R0} ${f/R0/R1}
nccmp -d -v Rnet -v RadT -t 1e-3 ${f/R0/R0} ${f/R0/R1}
doneOutput: |
Collaborator
Author
|
Hi @Whyborn, do you mind taking a look at the new diagnostic variables being added in this PR? I'm wary that changing the core data structures could impact the coupled model? |
Contributor
|
I'll have a proper look at it when I get back on Thursday |
Whyborn
reviewed
Mar 5, 2026
Contributor
Whyborn
left a comment
Whyborn
left a comment
There was a problem hiding this comment.
Looks good to me, just that question about air%rlam. Should we just remove that everywhere now?
Whyborn
approved these changes
Mar 5, 2026
Collaborator
Author
Possibly, although I think I'll leave that for a separate PR. The replacement of |
SeanBryan51
deleted the
cable-output-introduce-diagnostic-variables-for-cable-outputs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces diagnostic variables for CABLE outputs to compute various diagnostics outside the output module. This is required to bring in the new parallel I/O output module (#655), where output fields are associated with a pointer to an array which is written.
Type of change
Please delete options that are not relevant.
Checklist
Testing
Outputs contain precision level differences in variables
RnetandRadTdue to round off errors in the calculation of the diagnostic. All other variables are bitwise compatible.📚 Documentation preview 📚: https://cable--688.org.readthedocs.build/en/688/