Skip to content

Add carbon molar mass physical constant#687

Merged
SeanBryan51 merged 1 commit intomainfrom
cable-output-add-carbon-molar-mass-constant
Feb 24, 2026
Merged

Add carbon molar mass physical constant#687
SeanBryan51 merged 1 commit intomainfrom
cable-output-add-carbon-molar-mass-constant

Conversation

@SeanBryan51
Copy link
Collaborator

@SeanBryan51 SeanBryan51 commented Feb 23, 2026

This change replaces the magic number 1.201e-5 with a carbon molar mass constant (units: $\mu g / mol$) in the cable output module.

Type of change

Please delete options that are not relevant.

  • New or updated documentation

Checklist

  • The new content is accessible and located in the appropriate section
  • I have checked that links are valid and point to the intended content
  • I have checked my code/text and corrected any misspellings

Testing

  • Are the changes bitwise-compatible with the main branch? If working on an optional feature, are the results bitwise-compatible when this feature is off? If yes, copy benchcab output showing successful completion of the bitwise compatibility tests or equivalent results below this line.
2026-02-23 17:04:18,445 - INFO - benchcab.benchcab.py:380 - Running comparison tasks...
2026-02-23 17:04:18,472 - INFO - benchcab.benchcab.py:381 - tasks: 168 (models: 2, sites: 42, science configurations: 4)
2026-02-23 17:07:09,718 - INFO - benchcab.benchcab.py:391 - 0 failed, 168 passed

📚 Documentation preview 📚: https://cable--687.org.readthedocs.build/en/687/

@SeanBryan51 SeanBryan51 force-pushed the cable-output-add-carbon-molar-mass-constant branch from fdb71b0 to 9543e39 Compare February 23, 2026 01:23
@SeanBryan51 SeanBryan51 requested review from a team and bschroeter and removed request for a team February 23, 2026 22:58
Copy link
Contributor

@bschroeter bschroeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally approved, however, I question why we are keeping commented code in the source? Is there a reason why it is still there?

@SeanBryan51
Copy link
Collaborator Author

Thanks Ben

I question why we are keeping commented code in the source? Is there a reason why it is still there?

The comments will be removed in #688 🙂

@SeanBryan51
Copy link
Collaborator Author

As benchcab doesn't currently enable CASA-CNP, I've manually tested a CASA run using these scripts: https://github.com/SeanBryan51/crujra_accessN96_1h/tree/casa-cnp-configuration-serial - results are bitwise identical to main

@SeanBryan51 SeanBryan51 merged commit 0da1c36 into main Feb 24, 2026
5 checks passed
@SeanBryan51 SeanBryan51 deleted the cable-output-add-carbon-molar-mass-constant branch February 24, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants