Add carbon molar mass physical constant#687
Merged
SeanBryan51 merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
fdb71b0 to
9543e39
Compare
5 tasks
bschroeter
approved these changes
Feb 24, 2026
Contributor
bschroeter
left a comment
There was a problem hiding this comment.
Functionally approved, however, I question why we are keeping commented code in the source? Is there a reason why it is still there?
Collaborator
Author
|
Thanks Ben
The comments will be removed in #688 🙂 |
Collaborator
Author
|
As benchcab doesn't currently enable CASA-CNP, I've manually tested a CASA run using these scripts: https://github.com/SeanBryan51/crujra_accessN96_1h/tree/casa-cnp-configuration-serial - results are bitwise identical to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces the magic number$\mu g / mol$ ) in the cable output module.
1.201e-5with a carbon molar mass constant (units:Type of change
Please delete options that are not relevant.
Checklist
Testing
📚 Documentation preview 📚: https://cable--687.org.readthedocs.build/en/687/