feat: add ZarrsArray
#147
Draft
feat: add ZarrsArray
#147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love this!
See zarr-developers/zarr-python#3678. Telling claude to copy tensorstore works great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC for using
zarrs'Arrayfrom python. Nativezarrsperformance in Python 🚀🚀🚀. It just layers overzarr.Arrayand replaces__getitem__and__setitem__. The advantage over the codec pipeline is that all chunking logic / reassembly happens on the Rust side.It'd be amazing if there was some way to make this usable by
zarr-python(similarly to the codec pipeline) sodasketc can use it.Also maybe it should be lazy by default, currently opt-in with
.lazyRound trip benchmark
Disclosure: I haven't reviewed this thoroughly, Claude did most of the implementation.