Skip to content

Apply yii2-app-advanced modern Bootstrap5 theme.#337

Open
terabytesoftw wants to merge 5 commits intoyiisoft:masterfrom
terabytesoftw:feature_2
Open

Apply yii2-app-advanced modern Bootstrap5 theme.#337
terabytesoftw wants to merge 5 commits intoyiisoft:masterfrom
terabytesoftw:feature_2

Conversation

@terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass?

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (303b914) to head (fa8338b).

Additional details and impacted files
@@             Coverage Diff              @@
##              master      #337    +/-   ##
============================================
  Coverage     100.00%   100.00%            
  Complexity        46        46            
============================================
  Files             13        13            
  Lines            483       659   +176     
============================================
+ Hits             483       659   +176     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Applies a more modern Bootstrap 5–styled UI across the public Site pages (home/login/contact/about/error) and updates branding assets (Yii3 logos) and documentation screenshots to match.

Changes:

  • Added new Yii3 SVG logo variants and switched footer (and some page layouts) to use them.
  • Redesigned Home, Login, and Contact pages with new layout structure and accompanying CSS (hero banner, split-card auth/contact screens, extension cards).
  • Improved meta tag handling (only emit description/keywords when provided) and hardened error status code detection.

Reviewed changes

Copilot reviewed 11 out of 27 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
web/images/yii3_full_white_for_dark.svg Adds new white-on-dark Yii3 logo asset for brand panels/hero.
web/images/yii3_full_for_light.svg Adds full-color Yii3 logo asset intended for light theme usage.
web/images/yii3_full_for_dark.svg Adds Yii3 logo variant intended for dark theme usage.
web/images/yii3_full_black_for_light.svg Adds black-on-light Yii3 logo asset (used on mobile in login/contact).
web/css/site.css Updates navbar logout styling and adds new theme CSS for hero/auth/contact/cards and dark-mode tweaks.
views/site/login.php Rebuilds login screen as a split card layout + sets page meta params.
views/site/index.php Replaces default landing page with hero + extension grid + sets page meta params.
views/site/error.php Uses HttpException check to derive status code more safely.
views/site/contact.php Rebuilds contact screen as split card layout + sets page meta params + changes success-state UI.
views/site/about.php Adds page meta params and adjusts centered layout content.
views/layouts/main.php Moves <title> placement and continues using _head for meta/assets registration.
views/layouts/_header.php Updates logout link class to match Bootstrap nav-link styling.
views/layouts/_head.php Only registers description/keywords meta tags when values are non-empty.
views/layouts/_footer.php Uses app name in copyright and switches footer logos to new Yii3 SVGs.
tests/Acceptance/HomeCest.php Updates homepage assertion to use Yii::$app->name.
docs/images/error-dark.png Updates documentation screenshot to match new error page styling.
Comments suppressed due to low confidence (1)

views/site/contact.php:28

  • The contact success state checks for a success flash, but it never renders the flash message set in SiteController::actionContact() (currently: "Thank you for contacting us..."). This is a behavioral regression (users won’t see the actual success message) and will break existing functional/acceptance tests that assert on the flash text. Render Yii::$app->session->getFlash('success') (encoded) in this branch, or keep the previous message in the UI and update tests accordingly.
<?php if (Yii::$app->session->hasFlash('success')): ?>

<div class="site-contact-success d-flex align-items-center justify-content-center text-center">
    <div class="site-contact-success-content mx-auto">
        <h1 class="display-6 fw-semibold mb-3">Message sent</h1>

        <?php if (YII_DEBUG && Yii::$app->mailer->useFileTransport): ?>
            <p class="text-body-tertiary small mb-4">
                Development mode: email saved under
                <code><?= Yii::getAlias(Yii::$app->mailer->fileTransportPath) ?></code>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the Yii2 advanced app UI to a Bootstrap 5–styled theme, including new branding assets, updated page layouts (home/login/contact), and improved SEO meta handling via layout parameters.

Changes:

  • Add new Yii3 logo assets (light/dark variants) and update footer/login/contact/home to use them.
  • Redesign the home page hero + extension cards, and redesign login/contact pages into a split-card layout with new CSS.
  • Add per-page meta_description/meta_keywords params and conditionally register those meta tags in the layout head.

Reviewed changes

Copilot reviewed 11 out of 27 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
web/images/yii3_full_white_for_dark.svg Adds new white-on-dark Yii3 logo used in branded panels.
web/images/yii3_full_for_light.svg Adds full-color Yii3 logo for light contexts (footer).
web/images/yii3_full_for_dark.svg Adds full-color Yii3 logo adapted for dark theme (footer).
web/images/yii3_full_black_for_light.svg Adds black logo variant for light contexts (mobile login/contact).
web/css/site.css Updates navbar logout styling and adds new theme styles (login/contact split card, hero banner, extension cards, captcha tweaks).
views/site/login.php Replaces login page layout with split-card design and adds page-level SEO params.
views/site/index.php Replaces the default landing page with a hero banner + extension card grid and adds SEO params.
views/site/error.php Makes status code extraction safer by checking HttpException.
views/site/contact.php Replaces contact page layout with split-card design, tweaks captcha markup, and adds SEO params.
views/site/about.php Adds page-level SEO params.
views/layouts/main.php Adjusts head/title ordering in the layout.
views/layouts/_header.php Updates logout link classes to match new navbar styling.
views/layouts/_head.php Registers description/keywords meta tags only when provided.
views/layouts/_footer.php Uses app name and updates footer Yii logo images to the new Yii3 assets.
tests/Acceptance/HomeCest.php Updates the acceptance assertion to expect Yii::$app->name instead of a hard-coded string.
docs/images/error-dark.png Adds updated documentation screenshot/image asset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the Yii2 basic app UI to a Bootstrap 5 “advanced-like” theme by refreshing key pages (home/login/contact), updating shared layout behavior (meta tags, footer/header), and adding new branding assets.

Changes:

  • Add new Yii3 logo SVG variants and update footer/login imagery to support light/dark themes.
  • Redesign Home, Login, and Contact views (hero banner, extension cards, split-card auth/contact layouts) and expand supporting CSS.
  • Update layout meta-tag registration to only emit description/keywords when provided, and adjust footer copyright text/test expectations.

Reviewed changes

Copilot reviewed 11 out of 27 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
web/images/yii3_full_white_for_dark.svg Adds a white-on-dark full Yii3 logo asset for dark/brand panels.
web/images/yii3_full_for_light.svg Adds a full-color Yii3 logo asset intended for light backgrounds.
web/images/yii3_full_for_dark.svg Adds a full-color Yii3 logo asset intended for dark theme usage.
web/images/yii3_full_black_for_light.svg Adds a black-on-light Yii3 logo asset for mobile/light contexts.
web/css/site.css Updates navbar logout styling; adds split-card login/contact styling, captcha blending, hero banner, and extension-card styles.
views/site/login.php Rebuilds login page into a split-card layout with brand panel and updated metadata.
views/site/index.php Replaces the default landing page with a hero banner and a grid of extension “cards”; adds page metadata.
views/site/error.php Makes status-code detection explicit via HttpException for error rendering.
views/site/contact.php Rebuilds contact page into a split-card layout; adjusts form layout and adds page metadata.
views/site/about.php Adds meta description/keywords for the About page.
views/layouts/main.php Moves the <title> tag after $this->head() within <head>.
views/layouts/_header.php Ensures the logout link uses nav-link logout class for updated CSS targeting.
views/layouts/_head.php Registers meta description/keywords only when non-empty.
views/layouts/_footer.php Switches copyright to Yii::$app->name and updates footer logo assets.
tests/Acceptance/HomeCest.php Updates homepage assertion to expect the configured app name.
docs/images/error-dark.png Adds a dark-theme error-page screenshot to docs assets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

use yii\bootstrap5\Html;

$this->title = 'Login';
$this->title = 'Login to your account';
use yii\captcha\Captcha;

$this->title = 'Contact';
$this->title = 'Contact us';
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants