TASK: Add RedirectMiddleware and make Flow/Neos 7 compatible

[albe]

• Add middleware
• Fix/improve communication from Provider to Middleware for redirect
• Remove old component
• Update Settings

[albe]

See neos/flow-development-collection#2019 (comment)

Though we do not even have access to the ActionResponse in the TokenProvider, so this might become a bit harder to achieve than anticipated. If anyone has a good idea, just shoot.
I'm still thinking if it wouldn't make more sense to use the entryPoint configuration for the login redirect and use a middleware that checks for the setup redirect.

[gerdemann]

Can't this be solved with exceptions, as is the case here?

https://github.com/sandstorm/NeosTwoFactorAuthentication/blob/main/Classes/Security/Authentication/Provider/PersistentUsernameAndPasswordWithSecondFactorProvider.php#L68

[gerdemann]

@albe @johannessteu
I think it could work like that:
master...gerdemann:Neos7

[bwaidelich]

using exceptions for control flow is a bit quirky because of the overhead of throwing/catching exceptions (i.e. they have to create a full stack trace).
But in this case I also think that it's the nicer solution – and one top-level exception shouldn't do any harm

[gerdemann]

@albe Do you want to adapt your PR or should I create a new one? 😄

[bwaidelich]

@gerdemann btw I think your solution could be simplified to

    public function process(ServerRequestInterface $request, RequestHandlerInterface $next): ResponseInterface
    {
        try {
            $response = $next->handle($request);
        } catch (\Exception $exception) {
            if ($exception instanceof SecondFactorLoginException || $exception->getPrevious() instanceof SecondFactorLoginException) {
                return $this->redirectToLogin($request);
            } elseif ($exception instanceof SecondFactorSetupException || $exception->getPrevious() instanceof SecondFactorSetupException) {
                return $this->redirectToSetup($request);
            } else {
                throw $exception;
            }
        }
        return $response;
    }

[gerdemann]

Thank you, I have now adjusted this and created a PR. It doesn't matter to me whether this PR is adjusted or mine is merged. 😃
#8

[albe]

Closing in favor of #8