Fixed swapping stacks of the same item if the end stack is at max stack size#64
Open
CorranEveryone wants to merge 3 commits intoyannis300307:mainfrom
Open
Fixed swapping stacks of the same item if the end stack is at max stack size#64CorranEveryone wants to merge 3 commits intoyannis300307:mainfrom
CorranEveryone wants to merge 3 commits intoyannis300307:mainfrom
Conversation
…same items to already has a max stack
…the creative inventory or splitting stacks
…o fix the last change I made
Owner
|
Thank you for your contribution! I can't test the code this week but I will look into your PR as soon as I am available. |
Author
|
Sounds good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All I added is an if statement to the item swapping code, preventing it from swapping if the end stack is already at max.
I tested this on my N0120 and it works fine (I did encounter trial and error but I got it working in the end).
Also yes, I did make sure to include this fix in both the in same inventory item swapping and different inventory item swapping.