fix: Output content scripts in ascii to avoid utf8 encoding errors#2204
Merged
fix: Output content scripts in ascii to avoid utf8 encoding errors#2204
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
==========================================
+ Coverage 76.22% 76.50% +0.27%
==========================================
Files 115 115
Lines 3092 3094 +2
Branches 684 685 +1
==========================================
+ Hits 2357 2367 +10
+ Misses 652 646 -6
+ Partials 83 81 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Jorge Fuentes <jsfuentes@users.noreply.github.com>
Contributor
|
Thanks for helping make WXT better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Enforces ascii character set output, required by Chrome for chrome extensions.
For example, this will change 丂 →
\u4E02in the bundled output.Only set for content scripts, only content scripts have this problem.I'm just gonna enable it for everything, hard to know if unlisted scripts that are injected would also cause this problem or not. Shouldn't cause bundle size to increase too much.Manual Testing
N/A, see unit test changes.
Related Issue
This PR closes #353