chore: Extends i18n types to avoid `any` by PatrykKuniczak · Pull Request #2121 · wxt-dev/wxt

PatrykKuniczak · 2026-02-13T11:50:06Z

Overview

I've done my best, to type it, if anybody have better idea to do this, i'm open for edit suggestion.

Manual Testing

Let's see if CI pass

netlify · 2026-02-13T11:50:11Z

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name	Link
🔨 Latest commit	`a2e087f`
🔍 Latest deploy log	https://app.netlify.com/projects/creative-fairy-df92c4/deploys/69bbc2e026cebf00084f276b
😎 Deploy Preview	https://deploy-preview-2121--creative-fairy-df92c4.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

pkg-pr-new · 2026-02-13T11:51:42Z

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2121

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2121

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2121

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2121

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2121

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2121

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2121

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2121

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2121

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2121

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2121

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2121

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2121

wxt

npm i https://pkg.pr.new/wxt@2121

commit: a2e087f

codecov · 2026-02-13T11:52:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.19%. Comparing base (c6c9f65) to head (a2e087f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
- Coverage   76.39%   76.19%   -0.20%     
==========================================
  Files         115      115              
  Lines        3092     3092              
  Branches      684      684              
==========================================
- Hits         2362     2356       -6     
- Misses        649      653       +4     
- Partials       81       83       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aklinker1

I only looked a the test file. Revert those changes so the tests expect type errors for invalid function calls, then I'll look at the rest of this PR.

aklinker1 · 2026-02-21T17:42:04Z

packages/i18n/src/__tests__/types.test.ts

This file tests types by expecting type errors for invalid function calls. That means we need the // @ts-expect-error is present here. Revert it or find another way to test that type errors exist in these cases.

aklinker1

Woops, meant to request changes.

PatrykKuniczak · 2026-02-21T18:28:56Z

@aklinker1 Now it should be good

PatrykKuniczak · 2026-03-05T16:15:22Z

@aklinker1 Conflicts resolved 😄

PatrykKuniczak · 2026-03-10T19:58:16Z

@aklinker1 Again, let's check it :)

aklinker1 · 2026-03-18T21:16:31Z

@PatrykKuniczak What does this PR do? Why do your changes make the type-setup better? I'm not seeing anything immediately stand out after reviewing the changes. You made some good changes to make the internal code more type-safe, but I can't tell what your changes to the public APIs/types are doing

PatrykKuniczak · 2026-03-18T21:19:02Z

but I can't tell what your changes to the public APIs/types are doing

What do you mean?

aklinker1 · 2026-03-18T22:04:01Z

packages/i18n/src/build.ts

I pulled out all the changes to this file to #2201, they look good to me with a few tweaks.

aklinker1 · 2026-03-18T22:05:29Z

packages/i18n/src/index.ts

-export function createI18n<
-  T extends I18nStructure = DefaultI18nStructure,
->(): I18n<T> {
-  const t = (key: string, ...args: any[]) => {
+export function createI18n<T extends I18nStructure>(): I18n<T> {


OK, so we removed the default value from here... I'm not sure I like that. It is a breaking change for non-WXT projects. What do those projects use for the type param now?

If they doesn't provide any type, I18nStructure will take default value:

export type I18nStructure = { [K: string]: { plural: boolean; substitutions: 0 ... 9; };

I'm right?

packages/i18n/src/types.ts

aklinker1 · 2026-03-18T22:09:14Z

packages/i18n/src/types.ts

 };

+export interface I18n<T extends I18nStructure> {
+  t: string extends keyof T ? DefaultTFunction<keyof T & string> : TFunction<T>;


OK, so we're splitting up the typing... We're using the new DefaultTFunction type when.... T extends never? Is that what T defaults to when not provided in createI18n?

I18nStructure is defined as { [K: string]: I18nFeatures } - a signature with string keys
When T = I18nStructure, keyof T evaluates to string = true
So the condition string extends keyof T evaluates to string extends string
Therefore it uses DefaultTFunction (the "no type-safety" version)

packages/i18n/src/types.ts

aklinker1 · 2026-03-18T22:16:22Z

What do you mean?

What does this PR do? You haven't stated anywhere what the purpose of these changes are and it's hard for me to guess by just looking at the changes. Is the purpose just to remove any from the package?

If so, your PR title and description don't mention that at all.

PatrykKuniczak · 2026-03-19T06:41:20Z

What do you mean?

What does this PR do? You haven't stated anywhere what the purpose of these changes are and it's hard for me to guess by just looking at the changes. Is the purpose just to remove any from the package?

If so, your PR title and description don't mention that at all.

Ooo yeah, i've wanted to avoid any, i'll se e your PR and the we'll be able to discuss rest changes from this one

This reverts commit 61bd550.

PatrykKuniczak · 2026-03-19T09:33:45Z

@aklinker1 I hope now, it's more readable 😄

PatrykKuniczak requested review from Timeraa and aklinker1 as code owners February 13, 2026 11:50

PatrykKuniczak enabled auto-merge (squash) February 13, 2026 15:12

aklinker1 reviewed Feb 21, 2026

View reviewed changes

aklinker1 requested changes Feb 21, 2026

View reviewed changes

PatrykKuniczak force-pushed the chore/add-new-types-for-i18n branch from 18b6aee to d7363bb Compare February 21, 2026 18:29

aklinker1 force-pushed the main branch from db3e29d to adaae6e Compare February 22, 2026 23:30

PatrykKuniczak force-pushed the chore/add-new-types-for-i18n branch from d7363bb to d0e41a7 Compare March 5, 2026 16:14

PatrykKuniczak force-pushed the chore/add-new-types-for-i18n branch from 11dfd0e to e254767 Compare March 10, 2026 19:57

aklinker1 mentioned this pull request Mar 18, 2026

chore: Remove any from i18n's internal types #2201

Merged

aklinker1 reviewed Mar 18, 2026

View reviewed changes

PatrykKuniczak added 6 commits March 19, 2026 09:37

create types for t of i18n

c54ca6e

remove not longer necessary @ts-expect-error of types.test.ts

be8f919

add move generic approach for key type for DefaultTFunction

ee7294c

remove DefaultI18nStructure and use I18nStructure instead

5161cb0

Revert "remove not longer necessary @ts-expect-error of types.test.ts"

6c93aa3

This reverts commit 61bd550.

change types to allow only accepted combinations of arguments

a548c55

PatrykKuniczak force-pushed the chore/add-new-types-for-i18n branch from e254767 to a548c55 Compare March 19, 2026 08:37

PatrykKuniczak added 2 commits March 19, 2026 09:58

Remove unnecessary record of SubstitutionTuple

9bbceb9

Merge non-plural with 1 and 2 substitution type to 3+

ca97690

Simplify non-plural with substitutions of TFunction

a2e087f

PatrykKuniczak changed the title ~~chore: Add new types for i18n~~ chore: Extends i18n types to avoid any Mar 19, 2026

Uh oh!

Conversation

PatrykKuniczak commented Feb 13, 2026

Overview

Manual Testing

Uh oh!

netlify bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for creative-fairy-df92c4 ready!

Uh oh!

pkg-pr-new bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aklinker1 left a comment

Choose a reason for hiding this comment

Uh oh!

aklinker1 Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

aklinker1 left a comment

Choose a reason for hiding this comment

Uh oh!

PatrykKuniczak commented Feb 21, 2026

Uh oh!

PatrykKuniczak commented Mar 5, 2026

Uh oh!

PatrykKuniczak commented Mar 10, 2026

Uh oh!

aklinker1 commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PatrykKuniczak commented Mar 18, 2026

Uh oh!

aklinker1 Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aklinker1 Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PatrykKuniczak Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aklinker1 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

PatrykKuniczak Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aklinker1 commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PatrykKuniczak commented Mar 19, 2026

Uh oh!

PatrykKuniczak commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Feb 13, 2026 •

edited

Loading

pkg-pr-new bot commented Feb 13, 2026 •

edited

Loading

codecov bot commented Feb 13, 2026 •

edited

Loading

aklinker1 commented Mar 18, 2026 •

edited

Loading

aklinker1 Mar 18, 2026 •

edited

Loading

aklinker1 Mar 18, 2026 •

edited

Loading

aklinker1 commented Mar 18, 2026 •

edited

Loading