Groovy highlight regex fix + types#291
Merged
krystian-panek-vmltech merged 2 commits intomainfrom Feb 6, 2026
Merged
Conversation
|
|
||
| export const DEFAULT_THEME_ID = 'acm-dark'; | ||
|
|
||
| export function registerTheme(instance: Monaco) { |
Collaborator
Author
There was a problem hiding this comment.
future hook
jakub-gawronski-wttech
approved these changes
Feb 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves Groovy syntax highlighting in the Monaco editor by adding support for Groovy's slashy string (regex literal) syntax and introducing a custom theme system. It addresses Monaco editor configuration for Groovy language features that differ from Java, particularly string handling and regex literals.
Changes:
- Added custom theme registration with 'acm-dark' theme ID that extends 'vs-dark'
- Enhanced Groovy syntax highlighting with slashy string regex detection and improved rule ordering
- Reorganized tokenizer rules to prioritize Groovy-specific patterns over inherited Java patterns
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ui.frontend/src/utils/monaco/theme.ts | Introduces registerTheme function and changes DEFAULT_THEME_ID from 'vs-dark' to 'acm-dark' for custom theme support |
| ui.frontend/src/utils/monaco/groovy/syntax.ts | Adds slashy string regex detection, reorganizes tokenizer rules to prioritize Groovy patterns, and adds comprehensive inline comments |
| ui.frontend/src/components/CodeEditor.tsx | Registers the custom theme before language-specific configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #289