Address KeychainUtils FIXME and remove unused methods#25306
Open
Address KeychainUtils FIXME and remove unused methods#25306
Conversation
kean
commented
Feb 25, 2026
| } | ||
| } | ||
|
|
||
| func password(for username: String, serviceName: String, accessGroup: String? = nil) throws -> String? { |
Contributor
Author
There was a problem hiding this comment.
This had incorrect return type btw, it's non-optional.
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31231 | |
| Version | PR #25306 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 1b14c48 | |
| Installation URL | 7oa9qcfolukmo |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31231 | |
| Version | PR #25306 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 1b14c48 | |
| Installation URL | 0jcevp88n9gm8 |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
Contributor
|
Just a heads up – this one has test failures where the mocks are out of sync with the changes you've made |
kean
force-pushed
the
task/address-keychatinutils-fixme
branch
from
f282f57 to
1b14c48
Compare
Contributor
Author
|
I assumed these methods were unused, and they were. The mocks were obsolete. I updated everything to use |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.