You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Modules/Package.swift was changed without updating its corresponding Package.resolved.
If the change includes adding, removing, or editing a dependency please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
If the change to the Package.swift did not modify dependencies, ignoring this warning should be safe, but we recommend double checking and running the package resolution just in case.
.
⚠️
This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
The reason will be displayed to describe this comment to others. Learn more.
It's an interesting issue. The RCA is the following (generated):
Here's the problem: RemoteReaderCrossPostMeta is defined in Swift (WordPressKitModels), but the ObjC header in WordPressKitObjC only has @Class
RemoteReaderCrossPostMeta (a forward declaration). When Swift imports the WordPressKitObjC module, it can't resolve this forward-declared type to the
actual Swift class across module boundaries, so the crossPostMeta property is dropped from the Swift-visible interface.
I opted to fix it by convertingRemoteReaderCrossPostMeta, a small class, back to ObjC so that the entire RemoteReaderPost object graph is in ObjC. I also added nullability annotations (everything nullable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used TDD to reduce the risk of regression and performed manual tests.