Conversation
These were deleted during the last `gp_downloadmetadata` likely because of a 429 error from GlotPress. Various GlotPress actions were updated to retry when receiving a 429 in wordpress-mobile/release-toolkit#402, but `gp_downloadmetadata` was not one of them.
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
AliSoftware
approved these changes
Sep 2, 2022
Contributor
AliSoftware
left a comment
AliSoftware
left a comment
There was a problem hiding this comment.
- Version bump in
.xcconfigfiles - Latest app and metadata translations pulled from GlotPress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release_notes.txtupdates.stringsupdates.xcconfigfileNotice the additional "update metadata translations," there were missing release notes at the time I launched the deploy, and as a matter of fact, he
fr-FRrelease notes are still missing.Also notice the "new"
trmetadata for WordPress. This is a "fix" from what noted in #19267 (comment). The same goes for7c3289f(#19275).ASC metadata still get deleted when we get 429 because
gp_downloadmetadatawas not part of wordpress-mobile/release-toolkit#402 and didn't get the handy retry logic.