Skip to content

Fix use-after-free #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgarske merged 1 commit into from
Mar 19, 2026
+4 −4
Merged

Fix use-after-free #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/crypto/clu_evp_crypto.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ int wolfCLU_evp_crypto(const WOLFSSL_EVP_CIPHER* cphr, char* mode, byte* pwdKey,
WOLFSSL_BIO *in = NULL;
WOLFSSL_BIO *tmp = NULL;
WOLFSSL_EVP_CIPHER_CTX* ctx = NULL;
byte* decodedBase64 = NULL;

WC_RNG rng; /* random number generator declaration */

Expand Down Expand Up @@ -74,7 +75,6 @@ int wolfCLU_evp_crypto(const WOLFSSL_EVP_CIPHER* cphr, char* mode, byte* pwdKey,
if (fileIn != NULL) {
in = wolfSSL_BIO_new_file(fileIn, "rb");
if (in != NULL && !enc && isBase64) {
byte *decodedBase64 = NULL;
word32 decodeSz;

decodeSz = wolfSSL_BIO_get_len(in);
Expand All @@ -101,9 +101,6 @@ int wolfCLU_evp_crypto(const WOLFSSL_EVP_CIPHER* cphr, char* mode, byte* pwdKey,
}
}

if (decodedBase64 != NULL) {
XFREE(decodedBase64, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER);
}
}
}
else {
Expand Down Expand Up @@ -398,6 +395,9 @@ int wolfCLU_evp_crypto(const WOLFSSL_EVP_CIPHER* cphr, char* mode, byte* pwdKey,
wolfSSL_BIO_free(out);
wolfSSL_BIO_free(in);
wolfSSL_BIO_free(tmp);
if (decodedBase64 != NULL) {
XFREE(decodedBase64, HEAP_HINT, DYNAMIC_TYPE_TMP_BUFFER);
}

XMEMSET(key, 0, keySz);
XMEMSET(iv, 0 , ivSz);
Expand Down
Loading