Skip to content

Comments

cannon: Do not report status code 500 in metrics when websocket is closed due to client errors#5045

Merged
akshaymankar merged 2 commits intodevelopfrom
cannon-handle-ws-errors
Feb 19, 2026
Merged

cannon: Do not report status code 500 in metrics when websocket is closed due to client errors#5045
akshaymankar merged 2 commits intodevelopfrom
cannon-handle-ws-errors

Conversation

@akshaymankar
Copy link
Member

https://wearezeta.atlassian.net/browse/WPB-23590

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@akshaymankar akshaymankar requested review from a team as code owners February 18, 2026 17:31
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 18, 2026
@akshaymankar akshaymankar changed the title cannon: Do not report status code 500 when websocket is closed due to client errors cannon: Do not report status code 500 in metrics when websocket is closed due to client errors Feb 18, 2026
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@akshaymankar akshaymankar merged commit d36b9d2 into develop Feb 19, 2026
10 checks passed
@akshaymankar akshaymankar deleted the cannon-handle-ws-errors branch February 19, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants