fix: R8 keep rules for JNA and AVS/WebRTC to prevent login crash #4604
Merged
MohamadJaara merged 1 commit intodevelopfrom Feb 19, 2026
Merged
fix: R8 keep rules for JNA and AVS/WebRTC to prevent login crash #4604MohamadJaara merged 1 commit intodevelopfrom
MohamadJaara merged 1 commit intodevelopfrom
Conversation
Garzas
requested review from
MohamadJaara,
ohassine,
saleniuk and
sbakhtiarov
sbakhtiarov
approved these changes
Feb 19, 2026
ohassine
reviewed
Feb 19, 2026
Comment on lines
+49
to
+64
| -keep class com.sun.jna.** { *; } | ||
| -keep class * extends com.sun.jna.** { *; } | ||
| -keepclassmembers class com.sun.jna.Pointer { long peer; } | ||
|
|
||
| # AVS/WebRTC classes are accessed from native code (FlowManager_attach). | ||
| # Keep concrete names and members to avoid NoSuchMethodError/ClassNotFoundException at runtime. | ||
| -keep class org.webrtc.** { *; } | ||
| -keep class com.waz.call.FlowManager { *; } | ||
| -keep class com.waz.avs.VideoRenderer { *; } | ||
| -keep class com.waz.call.CaptureDevice { *; } | ||
| -keep class com.waz.media.manager.** { *; } | ||
| -keep class com.waz.service.call.** { *; } | ||
| -keep class com.waz.soundlink.SoundLinkAPI { *; } | ||
| -dontwarn org.webrtc.CalledByNative | ||
| -dontwarn org.webrtc.JniCommon | ||
| -dontwarn org.webrtc.audio.AudioDeviceModule |
Member
There was a problem hiding this comment.
Can we have them in calling module
MohamadJaara
approved these changes
Feb 19, 2026
Garzas
force-pushed
the
fix/r8-jna-avs-login-crash
branch
from
4c3953c to
d04c55f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
This PR fixes a release-only login crash caused by R8 shrinking/obfuscating classes used from native AVS/JNA code.
What was happening:
FlowManager_attachtried to access Java classes/methods by name.NoSuchMethodError/ClassNotFoundExceptionincom.waz.media.manager.*, then a native crash inlibavs.so.What was changed:
proguard-rules.profor:com.sun.jna.**(+Pointer.peer)com.waz.*,org.webrtc.*)-dontwarnentries to let R8 complete.Result:
internalCompatreleasebuilds and installs successfully.