Skip to content

fix: switch Google Maps Stats workflow from npm to pnpm#860

Merged
willtheorangeguy merged 2 commits intomainfrom
copilot/update-workflow-to-use-pnpm
Mar 4, 2026
Merged

fix: switch Google Maps Stats workflow from npm to pnpm#860
willtheorangeguy merged 2 commits intomainfrom
copilot/update-workflow-to-use-pnpm

Conversation

Copy link
Contributor

Copilot AI commented Mar 4, 2026

update-google-maps-stats.yml was using npm ci against a package-lock.json that is out of sync with the project's actual dependency manager (pnpm). This caused the workflow to fail due to @types/node version mismatches and missing lock file entries.

Changes

  • update-google-maps-stats.yml
    • Add pnpm/action-setup@v4 (version 9) before Node setup, matching astro.yml
    • Switch setup-node cache from npmpnpm; bump Node from 1820
    • Replace npm ci with pnpm install --frozen-lockfile (CI-safe, lock-respecting equivalent)
    • Replace npm run fetch-maps-stats with pnpm run fetch-maps-stats

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: willtheorangeguy <18339050+willtheorangeguy@users.noreply.github.com>
Copilot AI changed the title [WIP] Change workflow script to use pnpm for deployment fix: switch Google Maps Stats workflow from npm to pnpm Mar 4, 2026
@willtheorangeguy willtheorangeguy marked this pull request as ready for review March 4, 2026 15:46
Copilot AI review requested due to automatic review settings March 4, 2026 15:46
@willtheorangeguy willtheorangeguy merged commit 4251f95 into main Mar 4, 2026
11 checks passed
@willtheorangeguy willtheorangeguy deleted the copilot/update-workflow-to-use-pnpm branch March 4, 2026 15:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the scheduled “Update Google Maps Stats” workflow to use the repository’s actual package manager (pnpm) instead of npm, aligning dependency installation and caching with pnpm-lock.yaml to prevent CI failures from lockfile/version mismatches.

Changes:

  • Add pnpm/action-setup@v4 (pnpm v9) to the workflow.
  • Switch setup-node caching from npm to pnpm and bump Node.js from 18 to 20.
  • Replace npm ci / npm run ... with pnpm install --frozen-lockfile / pnpm run ....

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 13 to +17
steps:
- name: Checkout repository
uses: actions/checkout@v6

- name: Install pnpm
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow YAML indentation for steps is invalid: list items must be nested under steps: (e.g., steps:\n - name: ...). As written, the - name: entries are aligned with steps: which will cause the workflow file to fail YAML parsing.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants