Second pass attempt at fixing WValueDropDown + Various Bug Fixes by wallstop · Pull Request #216 · wallstop/unity-helpers

wallstop · 2026-02-27T19:15:12Z

Description

✓ Rework how the dropdown/selection works for WValueDropDown, specifically to help ODIN contexts
✓ Add FailedTestExporter
✓ Fix path for AttributeMetadataCache
✓ Ensure various editor tools and concepts utilize Undo appropriately

Related Issue

Fixes #209

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Refactor (code change that neither fixes a bug nor adds a feature)

Checklist

I have added tests that prove my fix is effective or my feature works
I have updated the documentation accordingly
I have updated the CHANGELOG
My changes do not introduce breaking changes, or breaking changes are documented

Copilot

Pull request overview

Reworks WValueDropDown (and related Odin drawers) dropdown rendering to avoid Linux-specific “phantom empty rows” by moving away from EditorGUI.Popup toward GenericMenu-driven selection, and updates the changelog accordingly.

Changes:

Replaced the small-list WValueDropDownDrawer selection UI with an EditorGUI.DropdownButton + GenericMenu flow.
Updated Odin drawers (WValueDropDown, StringInList, IntDropDown) to consistently use the popup/menu approach (removing the page-size threshold branch).
Added an Unreleased changelog entry describing the fix.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
Editor/CustomDrawers/WValueDropDownDrawer.cs	Switches non-paged IMGUI selection from `EditorGUI.Popup` to `GenericMenu` selection.
Editor/CustomDrawers/Odin/WValueDropDownOdinDrawer.cs	Removes page-size branching; always uses the popup/menu selection path.
Editor/CustomDrawers/Odin/StringInListOdinDrawer.cs	Removes page-size branching; always uses the popup/menu selection path.
Editor/CustomDrawers/Odin/IntDropDownOdinDrawer.cs	Removes page-size branching; always uses the popup/menu selection path.
CHANGELOG.md	Adds Unreleased note describing the dropdown rendering fix.

CHANGELOG.md

Editor/CustomDrawers/WValueDropDownDrawer.cs

Editor/CustomDrawers/Odin/WValueDropDownOdinDrawer.cs

Editor/CustomDrawers/Odin/StringInListOdinDrawer.cs

Editor/CustomDrawers/Odin/IntDropDownOdinDrawer.cs

Copilot

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.

Editor/CustomEditors/TexturePlatformOverrideEntryDrawer.cs

Editor/CustomDrawers/IntDropDownDrawer.cs

Copilot

Pull request overview

Copilot reviewed 33 out of 34 changed files in this pull request and generated 5 comments.

Editor/CustomDrawers/WValueDropDownDrawer.cs

Editor/CustomDrawers/StringInListDrawer.cs

scripts/lint-drawer-multiobject.ps1

Tests/Editor/CustomDrawers/IntDropDownDrawerMultiObjectTests.cs

Editor/CustomEditors/TexturePlatformOverrideEntryDrawer.cs

Copilot

Pull request overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 3 comments.

scripts/lint-drawer-multiobject.ps1

Editor/CustomEditors/TexturePlatformOverrideEntryDrawer.cs

Copilot

Pull request overview

Copilot reviewed 125 out of 164 changed files in this pull request and generated 3 comments.

CHANGELOG.md

Editor/CustomDrawers/IntDropDownDrawer.cs

CHANGELOG.md

Copilot

Pull request overview

Copilot reviewed 138 out of 177 changed files in this pull request and generated 1 comment.

.githooks/pre-commit

Copilot

Pull request overview

Copilot reviewed 150 out of 189 changed files in this pull request and generated 3 comments.

Editor/CustomEditors/TexturePlatformOverrideEntryDrawer.cs

Copilot

Pull request overview

Copilot reviewed 166 out of 205 changed files in this pull request and generated 2 comments.

Editor/CustomDrawers/Odin/IntDropDownOdinDrawer.cs

Editor/CustomEditors/TexturePlatformOverrideEntryDrawer.cs

Copilot

Pull request overview

Copilot reviewed 191 out of 230 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 226 out of 264 changed files in this pull request and generated 3 comments.

Copilot · 2026-03-03T05:13:30Z

Tests/Editor/TestTypes/MultiObjectIntDropDownTarget.cs

+// MIT License - Copyright (c) 2025 wallstop
+// Full license text: https://github.com/wallstop/unity-helpers/blob/main/LICENSE


The license header year is 2025, but the repo’s license-year audit checks the header year against the git creation year (and CURRENT_YEAR is 2026 for untracked files). Since this file is being added/modified now, this will likely fail scripts/audit-license-years.sh / license-year-audit.yml. Update the header year to the correct creation year (typically 2026 for new files), or run scripts/update-license-headers.sh to auto-fix.

Copilot · 2026-03-03T05:13:31Z

Tests/Editor/CustomDrawers/TestTypes/MultiObjectWValueDropDownTarget.cs

+// MIT License - Copyright (c) 2025 wallstop
+// Full license text: https://github.com/wallstop/unity-helpers/blob/main/LICENSE


The license header year is 2025, but the repo’s license-year audit checks the header year against the git creation year (and CURRENT_YEAR is 2026 for untracked files). Since this file is being added/modified now, this will likely fail scripts/audit-license-years.sh / license-year-audit.yml. Update the header year to the correct creation year (typically 2026 for new files), or run scripts/update-license-headers.sh to auto-fix.

Copilot · 2026-03-03T05:13:31Z

Tests/Editor/CustomDrawers/TestTypes/IntDropDownVeryLargeOptionsAsset.cs

+// MIT License - Copyright (c) 2025 wallstop
+// Full license text: https://github.com/wallstop/unity-helpers/blob/main/LICENSE


The license header year is 2025, but the repo’s license-year audit checks the header year against the git creation year (and CURRENT_YEAR is 2026 for untracked files). Since this file is being added/modified now, this will likely fail scripts/audit-license-years.sh / license-year-audit.yml. Update the header year to the correct creation year (typically 2026 for new files), or run scripts/update-license-headers.sh to auto-fix.

Second pass attempt at fixing WValueDropDown

0309e98

wallstop requested a review from Copilot February 27, 2026 19:15

Copilot started reviewing on behalf of wallstop February 27, 2026 19:15 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

PR feedback

55258ff

wallstop requested a review from Copilot February 28, 2026 00:55

Copilot started reviewing on behalf of wallstop February 28, 2026 00:55 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

Editor/CustomEditors/TexturePlatformOverrideEntryDrawer.cs Show resolved Hide resolved

Editor/CustomDrawers/IntDropDownDrawer.cs Outdated Show resolved Hide resolved

Editor/CustomDrawers/IntDropDownDrawer.cs Outdated Show resolved Hide resolved

PR feedback

c6e6653

wallstop requested a review from Copilot February 28, 2026 18:54

Copilot started reviewing on behalf of wallstop February 28, 2026 18:55 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

PR feedback

d137756

wallstop requested a review from Copilot February 28, 2026 20:05

Copilot started reviewing on behalf of wallstop February 28, 2026 20:06 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

scripts/lint-drawer-multiobject.ps1 Show resolved Hide resolved

Editor/CustomEditors/TexturePlatformOverrideEntryDrawer.cs Show resolved Hide resolved

Editor/CustomEditors/TexturePlatformOverrideEntryDrawer.cs Outdated Show resolved Hide resolved

PR feedback, bug fixes

cfe2038

wallstop requested a review from Copilot March 1, 2026 20:00

wallstop changed the title ~~Second pass attempt at fixing WValueDropDown~~ Second pass attempt at fixing WValueDropDown + Various Bug Fixes Mar 1, 2026

Copilot started reviewing on behalf of wallstop March 1, 2026 20:01 View session

Copilot AI reviewed Mar 1, 2026

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

Editor/CustomDrawers/IntDropDownDrawer.cs Outdated Show resolved Hide resolved

CHANGELOG.md Show resolved Hide resolved

PR feedback

92bfef1

wallstop requested a review from Copilot March 2, 2026 01:11

Copilot started reviewing on behalf of wallstop March 2, 2026 01:12 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

.githooks/pre-commit Outdated Show resolved Hide resolved

PR feedback

81fed3a

wallstop requested a review from Copilot March 2, 2026 03:33

Copilot started reviewing on behalf of wallstop March 2, 2026 03:33 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Editor/CustomEditors/TexturePlatformOverrideEntryDrawer.cs Show resolved Hide resolved

Editor/CustomEditors/TexturePlatformOverrideEntryDrawer.cs Show resolved Hide resolved

Editor/CustomEditors/TexturePlatformOverrideEntryDrawer.cs Outdated Show resolved Hide resolved

PR feedback

9e3e8aa

wallstop added 2 commits March 1, 2026 21:59

Local issues

2aa7452

Pre-push fixes

3cedb74

wallstop requested a review from Copilot March 2, 2026 18:18

Copilot started reviewing on behalf of wallstop March 2, 2026 18:19 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Editor/CustomDrawers/Odin/IntDropDownOdinDrawer.cs Outdated Show resolved Hide resolved

Editor/CustomEditors/TexturePlatformOverrideEntryDrawer.cs Show resolved Hide resolved

More CI/CD

9c0db9d

wallstop requested a review from Copilot March 2, 2026 22:25

Copilot started reviewing on behalf of wallstop March 2, 2026 22:26 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

PR feedback

343aa85

wallstop requested a review from Copilot March 3, 2026 05:04

Copilot started reviewing on behalf of wallstop March 3, 2026 05:05 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

wallstop merged commit 5c02cd8 into main Mar 3, 2026
42 checks passed

wallstop deleted the dev/wallstop/wvalue-drop-down-2 branch March 3, 2026 05:17

		// MIT License - Copyright (c) 2025 wallstop
		// Full license text: https://github.com/wallstop/unity-helpers/blob/main/LICENSE

Conversation

wallstop commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Type of Change

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

wallstop commented Feb 27, 2026 •

edited

Loading