Add +N overflow for read receipt#56
Merged
viktorstrate merged 2 commits intoviktorstrate:mainfrom Mar 1, 2026
Merged
Conversation
d49db39 to
6336bff
Compare
Owner
|
Awesome! Eventually I'd really like a popover that shows a list of all the users that has seen the given message, similar to what Element does. It can otherwise be frustrating to figure out whether a specific person has seen your message if they're a part of the
Do you want to add this as well while you're at it? Otherwise, I'd happily merge it as is. I think the code would look something like this: view
.popover(isPresented: $showPopover) {
List(users) { userId in
Label {
avatarImage(forUserId: userId)
}, {
Text(userDisplayName(forUserId: userId))
}
}
} |
Contributor
Author
|
I'll give it a go! |
Contributor
Author
|
@viktorstrate Ready for review. Used LazyVStack instead of List because List didn't automatically set its size based on the number of users in the list.
|
Owner
|
Looks great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds a +N overflow read status indicator with inspiration from Element Web.
1-4 receipts: All avatars are shown
More than 5 receipts: +N text + 3 most recent avatars
Tested on macOS 26.3
Closes #48