Fix icon alignments, clipping in sidebar#53
Merged
viktorstrate merged 1 commit intoviktorstrate:mainfrom Feb 27, 2026
Merged
Conversation
On macOS Tahoe, room icons don't quite behave as expected compared to older macOS releases. When no room icon can be loaded, the system icon is terribly misaligned as it is too small to fit the space it's given. When a room icon is found, it takes the full space, getting clipped in the process. I'm not entirely sure what the cause of the issue is, given that I haven't seen this behavior in other apps, but I suspect there's an issue with image sizing parameters internally. To work around this, I've made some minor modifications to the sidebar entry. First, system icons are now centered inside an invisible rounded rectangle to make sure it lines up correctly in the space given. Likewise, the image inside the label is given a frame, constraining its size to 22 points. To allow this to respect Dynamic Type features, this value is recorded as a ScaledMetric value, meaning it should adjust when the Dynamic Type rules are adjusted. Signed-off-by: Marquis Kurt <software@marquiskurt.net>
Owner
|
Works fine on macOS Sonoma as well, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS Tahoe, room icons don't quite behave as expected compared to older macOS releases. When no room icon can be loaded, the system icon is terribly misaligned as it is too small to fit the space it's given. When a room icon is found, it takes the full space, getting clipped in the process. I'm not entirely sure what the cause of the issue is, given that I haven't seen this behavior in other apps, but I suspect there's an issue with image sizing parameters internally.
To work around this, I've made some minor modifications to the sidebar entry. First, system icons are now centered inside an invisible rounded rectangle to make sure it lines up correctly in the space given. Likewise, the image inside the label is given a frame, constraining its size to 22 points. To allow this to respect Dynamic Type features, this value is recorded as a ScaledMetric value, meaning it should adjust when the Dynamic Type rules are adjusted.
Before the changes:
After the changes: