fix(fetch): respect Request properties#688
Draft
balazsorban44 wants to merge 3 commits intovercel:mainfrom
Draft
fix(fetch): respect Request properties#688balazsorban44 wants to merge 3 commits intovercel:mainfrom
Request properties#688balazsorban44 wants to merge 3 commits intovercel:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 5c11df4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dkokotov
reviewed
Nov 5, 2023
| export async function fetch(info, init) { | ||
| init = addDuplexToInit(init) | ||
| if (info instanceof Request) { | ||
| init.method ??= info.method |
There was a problem hiding this comment.
I am not sure how far long this PR is, so the comment may be premature, but two thoughts:
- why are only these particular properties of
Requestare copied over. It has other many other properties which are also valid to be set via the second argument tofetch. E.g.mode,cache, and others. - I am not sure how this fixes Cloning a Request in edge runtime when running the dev server does not work correctly next.js#57905. That issue is about the
Requestconstructor not working properly when the first argument to it is aRequestinstance -fetchis not involved at all, though it is in some ways similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes vercel/next.js#41531, Fixes vercel/next.js#57905