fix: run extraction strategy on cache hits (#1455)#1866
Open
hafezparast wants to merge 1 commit intounclecode:developfrom
Open
fix: run extraction strategy on cache hits (#1455)#1866hafezparast wants to merge 1 commit intounclecode:developfrom
hafezparast wants to merge 1 commit intounclecode:developfrom
Conversation
…#1455) When cache_mode=ENABLED and a URL was already cached, the cache-hit path returned the old CrawlResult directly without calling aprocess_html(). This meant extraction strategies (LLM, CSS, etc.) were never applied to cached content — extracted_content was empty or stale. Now, when a cache hit occurs and config.extraction_strategy is set, the processing pipeline runs on the cached HTML so the extraction strategy is applied. Cache hits without an extraction strategy continue to return immediately (no behavior change). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache_mode=CacheMode.ENABLEDand a URL is cached, the cache-hit path returned the oldCrawlResultdirectly without callingaprocess_html()extracted_contentwas empty or staleconfig.extraction_strategyis set, runaprocess_html()on the cached HTML so the extraction pipeline executesRoot cause identified by @SohamKukreti in the issue comments.
Fixes #1455
Test plan
test_extraction_runs_on_cache_hit— warms cache without extraction, then hits cache withJsonCssExtractionStrategyand verifiesextracted_contentis populatedtest_cache_without_extraction_still_works— cache hit without extraction strategy returns normally🤖 Generated with Claude Code