Skip to content

fix: disable /execute_js endpoint by default #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jannahopp wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

fix: disable /execute_js endpoint by default #1860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions deploy/docker/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@
# Hooks are disabled by default for security (RCE risk). Set to "true" to enable.
HOOKS_ENABLED = os.environ.get("CRAWL4AI_HOOKS_ENABLED", "false").lower() == "true"

# /execute_js runs arbitrary JavaScript in the headless browser, which can
# make unrestricted network requests (bypassing any Python-level SSRF checks).
# Disabled by default. Set to "true" to enable.
EXECUTE_JS_ENABLED = os.environ.get("CRAWL4AI_EXECUTE_JS_ENABLED", "false").lower() == "true"

# ── default browser config helper ─────────────────────────────
def get_default_browser_config() -> BrowserConfig:
"""Get default BrowserConfig from config.yml."""
Expand Down Expand Up @@ -494,6 +499,8 @@ class MarkdownGenerationResult(BaseModel):
```

"""
if not EXECUTE_JS_ENABLED:
raise HTTPException(403, "/execute_js is disabled. Set CRAWL4AI_EXECUTE_JS_ENABLED=true to enable.")
validate_url_scheme(body.url)
from crawler_pool import get_crawler
try:
Expand All @@ -507,6 +514,10 @@ class MarkdownGenerationResult(BaseModel):
except Exception as e:
raise HTTPException(500, detail=str(e))

# Hide from MCP tool list when disabled
if not EXECUTE_JS_ENABLED:
del execute_js.__mcp_kind__


@app.get("/llm/{url:path}")
async def llm_endpoint(
Expand Down