Skip to content

fix: disable /config/dump endpoint by default #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jannahopp wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

fix: disable /config/dump endpoint by default #1857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions deploy/docker/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@
# Hooks are disabled by default for security (RCE risk). Set to "true" to enable.
HOOKS_ENABLED = os.environ.get("CRAWL4AI_HOOKS_ENABLED", "false").lower() == "true"

# /config/dump endpoint uses eval() and is disabled by default for security.
# Set to "true" to enable (e.g. for local development).
CONFIG_DUMP_ENABLED = os.environ.get("CRAWL4AI_CONFIG_DUMP_ENABLED", "false").lower() == "true"

# ── default browser config helper ─────────────────────────────
def get_default_browser_config() -> BrowserConfig:
"""Get default BrowserConfig from config.yml."""
Expand Down Expand Up @@ -311,6 +315,8 @@ async def get_token(req: TokenRequest):

@app.post("/config/dump")
async def config_dump(raw: RawCode):
if not CONFIG_DUMP_ENABLED:
raise HTTPException(403, "/config/dump is disabled. Set CRAWL4AI_CONFIG_DUMP_ENABLED=true to enable.")
try:
return JSONResponse(_safe_eval_config(raw.code.strip()))
except Exception as e:
Expand Down