Skip to content

fix: remove eval() on user-supplied expressions in computed fields #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jannahopp wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix: remove eval() on user-supplied expressions in computed fields #1855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crawl4ai/extraction_strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,7 +1227,12 @@ def _apply_transform(self, value, transform):
def _compute_field(self, item, field):
try:
if "expression" in field:
return eval(field["expression"], {}, item)
import logging
logging.getLogger(__name__).warning(
"Computed field expressions are disabled for security. "
"Use 'function' for programmatic access."
)
return field.get("default")
elif "function" in field:
return field["function"](item)
except Exception as e:
Expand Down