Skip to content

feat: cherry-pick docx-io, registry files, railway.json from PR#190; …#4846

Closed
arthrod wants to merge 1 commit intoudecode:mainfrom
arthrod:docxio
Closed

feat: cherry-pick docx-io, registry files, railway.json from PR#190; …#4846
arthrod wants to merge 1 commit intoudecode:mainfrom
arthrod:docxio

Conversation

@arthrod
Copy link
Collaborator

@arthrod arthrod commented Mar 1, 2026

…fix pnpm syntax and HeadingOptions export

Amp-Thread-ID: https://ampcode.com/threads/T-019caab6-c2d7-7129-95ca-102efd3c3af6

Checklist

  • pnpm typecheck
  • pnpm lint:fix
  • pnpm test
  • pnpm brl
  • pnpm changeset
  • ui changelog

…fix pnpm syntax and HeadingOptions export

Amp-Thread-ID: https://ampcode.com/threads/T-019caab6-c2d7-7129-95ca-102efd3c3af6
Co-authored-by: Amp <amp@ampcode.com>
@arthrod arthrod requested a review from a team March 1, 2026 19:10
@codesandbox
Copy link

codesandbox bot commented Mar 1, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2026

⚠️ No Changeset found

Latest commit: c39acf0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plate Ignored Ignored Mar 1, 2026 7:10pm

Request Review

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 1, 2026
@arthrod arthrod closed this Mar 1, 2026
@dosubot dosubot bot added the plugin:docx label Mar 1, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c39acf07a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

author: payload.author,
date: payload.date,
startToken: `${DOCX_INSERTION_START_TOKEN_PREFIX}${rawPayload}${DOCX_INSERTION_TOKEN_SUFFIX}`,
endToken: `${DOCX_INSERTION_END_TOKEN_PREFIX}${payload.id}${DOCX_INSERTION_TOKEN_SUFFIX}`,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Encode reconstructed tracked-change end tokens

parseDocxTrackedChanges rebuilds endToken with raw payload.id ([[DOCX_INS_END:${payload.id}]]) instead of encoding it, but export emits end tokens with encodeURIComponent(id) (see buildSuggestionEndToken). If a suggestion ID contains reserved characters (e.g. /, :, space), import searches for the wrong token string, so applyTrackedChangeSuggestions cannot locate the end marker and skips that change (the deletion branch has the same issue).

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin:docx size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant